Type checking a mapping/listing should be lazy #137

New Issue

2025-12-30T01:21:24+01:00

adam commented

2025-12-30 01:21:24 +01:00

Originally created by @bioball on GitHub (Apr 6, 2024).

Currently, accessing a property of type Mapping<TypeA, TypeB> or Listing<Type> will shallow-force the whole mapping/listing. The shallow-force gets skipped if the type is unknown or Any (e.g. Listing, or Listing<unknown>, or Listing<Any>).

This should not throw, but does currently:

hidden nums: Listing<Int> = new {
  throw("uh oh")
  1
}

result = nums[1]

This is related to #405

Originally created by @bioball on GitHub (Apr 6, 2024). Currently, accessing a property of type `Mapping<TypeA, TypeB>` or `Listing<Type>` will shallow-force the whole mapping/listing. The shallow-force gets skipped if the type is `unknown` or `Any` (e.g. `Listing`, or `Listing<unknown>`, or `Listing<Any>`). This should not throw, but does currently: ``` hidden nums: Listing<Int> = new { throw("uh oh") 1 } result = nums[1] ``` This is related to #405

adam added the bug label 2025-12-30 01:21:24 +01:00

adam closed this issue

2025-12-30 01:21:24 +01:00

adam commented

2025-12-30 01:21:24 +01:00

@harryjackson commented on GitHub (Apr 6, 2024):

This is just another example. The addition happens and we get 33 but at what point is the type checking meant to happen. Using the IntelliJ plugin I get warnings telling me I'm doing something stupid.

foo = new Listing<YamlRenderer> {
  11
}

bar = new Listing<String> {
  22
}

output {
  value = foo[0] + bar[0]
  renderer = new YamlRenderer{}
}

output

@harryjackson commented on GitHub (Apr 6, 2024): This is just another example. The addition happens and we get 33 but at what point is the type checking meant to happen. Using the IntelliJ plugin I get warnings telling me I'm doing something stupid. ```bash foo = new Listing<YamlRenderer> { 11 } bar = new Listing<String> { 22 } output { value = foo[0] + bar[0] renderer = new YamlRenderer{} } ``` output ```bash 33 ```

adam commented

2025-12-30 01:21:25 +01:00

@bioball commented on GitHub (Apr 7, 2024):

@harryjackson: what you're seeing is the #405 bug, rather than this one. To fix, you should add a type annotation to your properties:

foo: Listing<YamlRenderer> = new {
  11
}

bar: Listing<String> = new {
  22
}

output {
  value = foo[0] + bar[0]
  renderer = new YamlRenderer{}
}

@bioball commented on GitHub (Apr 7, 2024): @harryjackson: what you're seeing is the #405 bug, rather than this one. To fix, you should add a type annotation to your properties: ```groovy foo: Listing<YamlRenderer> = new { 11 } bar: Listing<String> = new { 22 } output { value = foo[0] + bar[0] renderer = new YamlRenderer{} } ```

adam referenced this issue

2025-12-30 01:24:26 +01:00

[PR #149] [Addition] Added IniRenderer and IniRenderer test cases #137 #428

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#137