[PR #1369] Add error hint when accessing the default value of a union type with no default #1051

New Issue

adam · 2025-12-30T01:28:30+01:00

adam commented

2025-12-30 01:28:30 +01:00

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/1369
Author: @HT154
Created: 12/14/2025
Status: 🔄 Open

Base: main ← Head: amend-union-no-default-hint

📝 Commits (3)

43e9f2e Add error hint when accessing the default value of a union type with no default
7c1aede Handle unions with default element but still no default value
5bb88d3 Update error message

📊 Changes

11 files changed (+121 additions, -4 deletions)

View changed files

📝 pkl-core/src/main/java/org/pkl/core/ast/member/DefaultPropertyBodyNode.java (+27 -2)
📝 pkl-core/src/main/java/org/pkl/core/ast/type/TypeNode.java (+8 -0)
📝 pkl-core/src/main/java/org/pkl/core/runtime/VmExceptionBuilder.java (+12 -2)
📝 pkl-core/src/main/resources/org/pkl/core/errorMessages.properties (+10 -0)
➕ pkl-core/src/test/files/LanguageSnippetTests/input/errors/noDefault3.pkl (+3 -0)
➕ pkl-core/src/test/files/LanguageSnippetTests/input/errors/noDefault4.pkl (+4 -0)
➕ pkl-core/src/test/files/LanguageSnippetTests/input/errors/noDefault5.pkl (+3 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/errors/noDefault2.err (+2 -0)
➕ pkl-core/src/test/files/LanguageSnippetTests/output/errors/noDefault3.err (+18 -0)
➕ pkl-core/src/test/files/LanguageSnippetTests/output/errors/noDefault4.err (+18 -0)
➕ pkl-core/src/test/files/LanguageSnippetTests/output/errors/noDefault5.err (+16 -0)

📄 Description

Resolves #1368

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/1369 **Author:** [@HT154](https://github.com/HT154) **Created:** 12/14/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `amend-union-no-default-hint` --- ### 📝 Commits (3) - [`43e9f2e`](https://github.com/apple/pkl/commit/43e9f2e916c51150ea12d202357bd48bba40333b) Add error hint when accessing the default value of a union type with no default - [`7c1aede`](https://github.com/apple/pkl/commit/7c1aededd096eebabde9757d0245efeb5dc782f8) Handle unions with default element but still no default value - [`5bb88d3`](https://github.com/apple/pkl/commit/5bb88d3d877cc4070b820ed7d9ef1521f8d0bd17) Update error message ### 📊 Changes **11 files changed** (+121 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `pkl-core/src/main/java/org/pkl/core/ast/member/DefaultPropertyBodyNode.java` (+27 -2) 📝 `pkl-core/src/main/java/org/pkl/core/ast/type/TypeNode.java` (+8 -0) 📝 `pkl-core/src/main/java/org/pkl/core/runtime/VmExceptionBuilder.java` (+12 -2) 📝 `pkl-core/src/main/resources/org/pkl/core/errorMessages.properties` (+10 -0) ➕ `pkl-core/src/test/files/LanguageSnippetTests/input/errors/noDefault3.pkl` (+3 -0) ➕ `pkl-core/src/test/files/LanguageSnippetTests/input/errors/noDefault4.pkl` (+4 -0) ➕ `pkl-core/src/test/files/LanguageSnippetTests/input/errors/noDefault5.pkl` (+3 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/errors/noDefault2.err` (+2 -0) ➕ `pkl-core/src/test/files/LanguageSnippetTests/output/errors/noDefault3.err` (+18 -0) ➕ `pkl-core/src/test/files/LanguageSnippetTests/output/errors/noDefault4.err` (+18 -0) ➕ `pkl-core/src/test/files/LanguageSnippetTests/output/errors/noDefault5.err` (+16 -0) </details> ### 📄 Description Resolves #1368 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:28:30 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#1051