[PR #1350] [MERGED] Omit superfluous newline when writing formatted content to stdout #1035

Closed
opened 2025-12-30 01:28:24 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/1350
Author: @bioball
Created: 12/5/2025
Status: Merged
Merged: 12/5/2025
Merged by: @bioball

Base: mainHead: fix-formatter-newline


📝 Commits (1)

  • 421f509 Omit superfluous newline when writing formatted content

📊 Changes

2 files changed (+55 additions, -7 deletions)

View changed files

📝 pkl-cli/src/main/kotlin/org/pkl/cli/CliFormatterCommand.kt (+8 -7)
pkl-cli/src/test/kotlin/org/pkl/cli/CliFormatterTest.kt (+47 -0)

📄 Description

Fixes an issue where an extra newline is added when writing formatted code to stdout.

Closes https://github.com/apple/pkl/issues/1346


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/1350 **Author:** [@bioball](https://github.com/bioball) **Created:** 12/5/2025 **Status:** ✅ Merged **Merged:** 12/5/2025 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `fix-formatter-newline` --- ### 📝 Commits (1) - [`421f509`](https://github.com/apple/pkl/commit/421f50925ae2894f8ca5539abbbe40979240430a) Omit superfluous newline when writing formatted content ### 📊 Changes **2 files changed** (+55 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `pkl-cli/src/main/kotlin/org/pkl/cli/CliFormatterCommand.kt` (+8 -7) ➕ `pkl-cli/src/test/kotlin/org/pkl/cli/CliFormatterTest.kt` (+47 -0) </details> ### 📄 Description Fixes an issue where an extra newline is added when writing formatted code to stdout. Closes https://github.com/apple/pkl/issues/1346 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:28:24 +01:00
adam closed this issue 2025-12-30 01:28:24 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#1035