[PR #1336] [CLOSED] Vendor paguro, fix an int overflow breaking large Lists #1025

New Issue

adam · 2025-12-30T01:28:20+01:00

adam commented

2025-12-30 01:28:20 +01:00

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/1336
Author: @HT154
Created: 12/2/2025
Status: ❌ Closed

Base: main ← Head: vendor-paguro

📝 Commits (1)

3596958 Vendor paguro, fix an int overflow breaking large Lists

📊 Changes

77 files changed (+13635 additions, -41 deletions)

View changed files

📝 bench/gradle.lockfile (+0 -1)
📝 buildSrc/src/main/kotlin/pklFatJar.gradle.kts (+0 -1)
📝 docs/gradle.lockfile (+0 -1)
📝 gradle/libs.versions.toml (+0 -3)
📝 pkl-cli/gradle.lockfile (+0 -1)
📝 pkl-codegen-java/gradle.lockfile (+0 -1)
📝 pkl-codegen-kotlin/gradle.lockfile (+0 -1)
📝 pkl-commons-cli/gradle.lockfile (+0 -1)
📝 pkl-config-java/gradle.lockfile (+0 -1)
📝 pkl-config-kotlin/gradle.lockfile (+0 -1)
📝 pkl-core/gradle.lockfile (+0 -1)
📝 pkl-core/pkl-core.gradle.kts (+6 -2)
📝 pkl-core/src/main/java/org/pkl/core/runtime/VmCollection.java (+2 -2)
📝 pkl-core/src/main/java/org/pkl/core/runtime/VmList.java (+5 -5)
📝 pkl-core/src/main/java/org/pkl/core/runtime/VmMap.java (+7 -7)
📝 pkl-core/src/main/java/org/pkl/core/runtime/VmSet.java (+7 -7)
📝 pkl-core/src/main/java/org/pkl/core/runtime/VmUtils.java (+1 -1)
➕ pkl-core/src/main/java/org/pkl/core/util/paguro/FunctionUtils.java (+41 -0)
➕ pkl-core/src/main/java/org/pkl/core/util/paguro/collections/AbstractUnmodIterable.java (+32 -0)
➕ pkl-core/src/main/java/org/pkl/core/util/paguro/collections/AbstractUnmodMap.java (+68 -0)

...and 57 more files

📄 Description

Paguro is unmaintained, so in lieu of replacing it entirely (which we'd like to do eventually) this PR vendors it to fix the bug.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/1336 **Author:** [@HT154](https://github.com/HT154) **Created:** 12/2/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `vendor-paguro` --- ### 📝 Commits (1) - [`3596958`](https://github.com/apple/pkl/commit/3596958eee0fc9a96ed2a7b8d449c8821ec6c45d) Vendor paguro, fix an int overflow breaking large `List`s ### 📊 Changes **77 files changed** (+13635 additions, -41 deletions) <details> <summary>View changed files</summary> 📝 `bench/gradle.lockfile` (+0 -1) 📝 `buildSrc/src/main/kotlin/pklFatJar.gradle.kts` (+0 -1) 📝 `docs/gradle.lockfile` (+0 -1) 📝 `gradle/libs.versions.toml` (+0 -3) 📝 `pkl-cli/gradle.lockfile` (+0 -1) 📝 `pkl-codegen-java/gradle.lockfile` (+0 -1) 📝 `pkl-codegen-kotlin/gradle.lockfile` (+0 -1) 📝 `pkl-commons-cli/gradle.lockfile` (+0 -1) 📝 `pkl-config-java/gradle.lockfile` (+0 -1) 📝 `pkl-config-kotlin/gradle.lockfile` (+0 -1) 📝 `pkl-core/gradle.lockfile` (+0 -1) 📝 `pkl-core/pkl-core.gradle.kts` (+6 -2) 📝 `pkl-core/src/main/java/org/pkl/core/runtime/VmCollection.java` (+2 -2) 📝 `pkl-core/src/main/java/org/pkl/core/runtime/VmList.java` (+5 -5) 📝 `pkl-core/src/main/java/org/pkl/core/runtime/VmMap.java` (+7 -7) 📝 `pkl-core/src/main/java/org/pkl/core/runtime/VmSet.java` (+7 -7) 📝 `pkl-core/src/main/java/org/pkl/core/runtime/VmUtils.java` (+1 -1) ➕ `pkl-core/src/main/java/org/pkl/core/util/paguro/FunctionUtils.java` (+41 -0) ➕ `pkl-core/src/main/java/org/pkl/core/util/paguro/collections/AbstractUnmodIterable.java` (+32 -0) ➕ `pkl-core/src/main/java/org/pkl/core/util/paguro/collections/AbstractUnmodMap.java` (+68 -0) _...and 57 more files_ </details> ### 📄 Description Paguro is unmaintained, so in lieu of replacing it entirely (which we'd like to do eventually) this PR vendors it to fix the bug. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:28:20 +01:00

adam closed this issue

2025-12-30 01:28:20 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#1025

[PR #1336] [CLOSED] Vendor paguro, fix an int overflow breaking large Lists #1025

📋 Pull Request Information

📝 Commits (1)

📊 Changes

📄 Description

[PR #1336] [CLOSED] Vendor paguro, fix an int overflow breaking large `List`s #1025