starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-11 14:20:35 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #1335] [MERGED] Fix parsing of URLs with plus signs #1022

New Issue
Closed
opened 2025-12-30 01:28:20 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:28:20 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/1335
Author: @bioball
Created: 12/2/2025
Status: ✅ Merged
Merged: 12/3/2025
Merged by: @bioball

Base: main ← Head: fix-uri-parsing

📝 Commits (3)

📊 Changes

3 files changed (+10 additions, -1 deletions)

View changed files

📝 pkl-core/src/main/java/org/pkl/core/util/IoUtils.java (+1 -1)
📝 pkl-core/src/test/files/LanguageSnippetTests/input/api/Resource.pkl (+6 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/api/Resource.pcf (+3 -0)

📄 Description

This fixes an issue where URLs with schemes that contain +, -, and . would not be parsed correctly.

For example, foo+bar:///?baz.pkl would turn into foo+bar:///%3Fbaz.pkl. The query param is lost, and turned into the path.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/1335 **Author:** [@bioball](https://github.com/bioball) **Created:** 12/2/2025 **Status:** ✅ Merged **Merged:** 12/3/2025 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `fix-uri-parsing` --- ### 📝 Commits (3) - [`c408c82`](https://github.com/apple/pkl/commit/c408c82183b74829dce35a8dfb70338efed6f056) Fix parsing of URLs with plus signs - [`294ff46`](https://github.com/apple/pkl/commit/294ff467f1f8e5203b6bb8892adecc402503ce1d) Update release notes - [`7946d1d`](https://github.com/apple/pkl/commit/7946d1d43066f692e544d30397cbdbe1650e7256) Undo changelog change ### 📊 Changes **3 files changed** (+10 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `pkl-core/src/main/java/org/pkl/core/util/IoUtils.java` (+1 -1) 📝 `pkl-core/src/test/files/LanguageSnippetTests/input/api/Resource.pkl` (+6 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/api/Resource.pcf` (+3 -0) </details> ### 📄 Description This fixes an issue where URLs with schemes that contain `+`, `-`, and `.` would not be parsed correctly. For example, `foo+bar:///?baz.pkl` would turn into `foo+bar:///%3Fbaz.pkl`. The query param is lost, and turned into the path. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:28:20 +01:00
adam closed this issue 2025-12-30 01:28:20 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#1022
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?