starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-04-29 03:37:12 +02:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

Refine external reader API (#762)

Browse Source 
* Encapsulate message transport by removing `ExternalReaderProcess.getTransport` and adding `getModuleResolver` and `getResourceResolver` methods
* Reuse `Random` instances within `ExternalReaderProcessImpl` and module/resource resolvers
* Externalize all `ExternalReaderProcessException` messages
* Add some missing doc comments to `ModuleKeyFactories` and `ResourceReaders` methods for external readers
* Move org.pkl.core.util.Readers to org.pkl.core.Readers
This commit is contained in:
Josh B
2024-10-31 16:51:25 -07:00
committed by GitHub
parent 66d751f093
commit e217cfcd6f
16 changed files with 89 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
pkl-core/src/main/resources/org/pkl/core/errorMessages.properties
View File

@@ -1117,3 +1117,6 @@ Failed to communicate with external reader process.
externalReaderDoesNotSupportScheme=\
External {0} reader does not support scheme `{1}`.
externalReaderAlreadyTerminated=\
External reader process has already terminated.