starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-03-19 07:43:59 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

Refine external reader API (#762)

Browse Source 
* Encapsulate message transport by removing `ExternalReaderProcess.getTransport` and adding `getModuleResolver` and `getResourceResolver` methods
* Reuse `Random` instances within `ExternalReaderProcessImpl` and module/resource resolvers
* Externalize all `ExternalReaderProcessException` messages
* Add some missing doc comments to `ModuleKeyFactories` and `ResourceReaders` methods for external readers
* Move org.pkl.core.util.Readers to org.pkl.core.Readers
This commit is contained in:
Josh B
2024-10-31 16:51:25 -07:00
committed by GitHub
parent 66d751f093
commit e217cfcd6f
16 changed files with 89 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pkl-cli/src/main/kotlin/org/pkl/cli/CliEvaluator.kt
View File

@@ -31,12 +31,12 @@ import org.pkl.commons.writeString
import org.pkl.core.EvaluatorBuilder
import org.pkl.core.ModuleSource
import org.pkl.core.PklException
import org.pkl.core.Readers
import org.pkl.core.module.ModulePathResolver
import org.pkl.core.runtime.ModuleResolver
import org.pkl.core.runtime.VmException
import org.pkl.core.runtime.VmUtils
import org.pkl.core.util.IoUtils
import org.pkl.core.util.Readers
private data class OutputFile(val pathSpec: String, val moduleUri: URI)

2
pkl-cli/src/main/kotlin/org/pkl/cli/CliImportAnalyzer.kt
View File

@@ -20,7 +20,7 @@ import org.pkl.commons.cli.CliCommand
import org.pkl.commons.createParentDirectories
import org.pkl.commons.writeString
import org.pkl.core.ModuleSource
import org.pkl.core.util.Readers
import org.pkl.core.Readers
class CliImportAnalyzer
@JvmOverloads

2
pkl-cli/src/main/kotlin/org/pkl/cli/CliTestRunner.kt
View File

@@ -19,10 +19,10 @@ import java.io.Writer
import org.pkl.commons.cli.*
import org.pkl.core.EvaluatorBuilder
import org.pkl.core.ModuleSource.uri
import org.pkl.core.Readers
import org.pkl.core.stdlib.test.report.JUnitReport
import org.pkl.core.stdlib.test.report.SimpleReport
import org.pkl.core.util.ErrorMessages
import org.pkl.core.util.Readers
class CliTestRunner
@JvmOverloads