From d7196e1207d7a057aa4c1c9552f0f5fa7ce78706 Mon Sep 17 00:00:00 2001 From: Daniel Chao Date: Mon, 4 Mar 2024 07:49:20 -0800 Subject: [PATCH] Docs fix: Java 8 is not supported (#283) Java 11 is the minimum version, rather than 8. --- docs/modules/kotlin-binding/pages/codegen.adoc | 2 +- docs/modules/pkl-cli/pages/index.adoc | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/modules/kotlin-binding/pages/codegen.adoc b/docs/modules/kotlin-binding/pages/codegen.adoc index c9858794..75437c7a 100644 --- a/docs/modules/kotlin-binding/pages/codegen.adoc +++ b/docs/modules/kotlin-binding/pages/codegen.adoc @@ -19,7 +19,7 @@ See xref:pkl-gradle:index.adoc#installation[Installation] in the Gradle plugin c === Java Library The `pkl-codegen-kotlin` library is available {uri-pkl-codegen-kotlin-maven-module}[from Maven Central]. -It requires Java 8 or higher and Kotlin 1.3 or higher. +It requires Java 11 or higher and Kotlin 1.3 or higher. ==== Gradle diff --git a/docs/modules/pkl-cli/pages/index.adoc b/docs/modules/pkl-cli/pages/index.adoc index 2bd2b9c0..fc73cdc3 100644 --- a/docs/modules/pkl-cli/pages/index.adoc +++ b/docs/modules/pkl-cli/pages/index.adoc @@ -32,10 +32,10 @@ For interactive development, the CLI includes a Read-Eval-Print Loop (REPL). The CLI comes in multiple flavors: * Native macOS executable for amd64 (tested on macOS 10.15) -* Native Linux executable for amd64 (tested on Oracle Linux 8) -* Native Linux executable for aarch64 (tested on Oracle Linux 8) +* Native Linux executable for amd64 +* Native Linux executable for aarch64 * Native Alpine Linux executable for amd64 (cross-compiled and tested on Oracle Linux 8) -* Java executable (tested with Java 8/11/14 on macOS and Oracle Linux) +* Java executable (tested with Java 11/17 on macOS and Oracle Linux) On macOS and Linux, we recommend using the native executables. They are self-contained, start up instantly, and run complex Pkl code much faster than the Java executable. @@ -48,7 +48,7 @@ whereas, the Alpine Linux executable is statically linked against _musl libc_ an ==== The Java executable works on multiple platforms and has a smaller binary size than the native executables. -However, it requires a Java 8 (or higher) runtime on the system path, has a noticeable startup delay, +However, it requires a Java 11 (or higher) runtime on the system path, has a noticeable startup delay, and runs complex Pkl code slower than the native executables. All flavors are built from the same codebase and undergo the same automated testing.