starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-09-13 13:21:47 +02:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

Enforce max collection sizes when decoding pkl-binary (#1831)

Browse Source
This commit is contained in:
Jen Basch
2026-08-25 08:28:28 -07:00
committed by GitHub
parent 79af6b1676
commit ae9160df51
4 changed files with 85 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkl-core/src/test/kotlin/org/pkl/core/PklBinaryDecoderTest.kt
+31
View File
@@ -230,4 +230,35 @@ class PklBinaryDecoderTest {
"Unexpected blank typealias module URI",
)
}
@Test
fun `decode collections too large`() {
assertExceptionCauseMessageContains(
byteArrayOf(0x93.toByte(), PklBinaryCode.OBJECT.code) +
strFoo +
strFoo +
byteArrayOf(0xdd.toByte(), 0, 1, 0, 0),
"Unable to decode object of length 65536, exceeded maximum collection size",
)
assertExceptionCauseMessageContains(
byteArrayOf(0x93.toByte(), PklBinaryCode.MAP.code, 0xdf.toByte(), 0, 1, 0, 0),
"Unable to decode map of length 65536, exceeded maximum collection size",
)
assertExceptionCauseMessageContains(
byteArrayOf(0x93.toByte(), PklBinaryCode.MAPPING.code, 0xdf.toByte(), 0, 1, 0, 0),
"Unable to decode mapping of length 65536, exceeded maximum collection size",
)
assertExceptionCauseMessageContains(
byteArrayOf(0x93.toByte(), PklBinaryCode.LIST.code, 0xdd.toByte(), 0, 1, 0, 0),
"Unable to decode list of length 65536, exceeded maximum collection size",
)
assertExceptionCauseMessageContains(
byteArrayOf(0x93.toByte(), PklBinaryCode.LISTING.code, 0xdd.toByte(), 0, 1, 0, 0),
"Unable to decode listing of length 65536, exceeded maximum collection size",
)
assertExceptionCauseMessageContains(
byteArrayOf(0x93.toByte(), PklBinaryCode.SET.code, 0xdd.toByte(), 0, 1, 0, 0),
"Unable to decode set of length 65536, exceeded maximum collection size",
)
}
}