Fix external reader process leak in pkl-server (#1885)
This commit is contained in:
1 parent
82fe176c69
commit
adaafc4045
7 files changed
+107
-38
No files matched your search
@@ -89,9 +89,10 @@ class Server(private val transport: MessageTransport) : AutoCloseable {
|
||||
*/
|
||||
override fun close() {
|
||||
transport.closeQuietly()
|
||||
for ((_, evaluator) in evaluators) {
|
||||
for ((evaluatorId, evaluator) in evaluators) {
|
||||
// if currently in use, blocks until cancellation complete
|
||||
evaluator.closeQuietly()
|
||||
externalReaderProcesses[evaluatorId]?.values?.forEach { it.closeQuietly() }
|
||||
}
|
||||
executor.shutdown()
|
||||
}
|
||||
@@ -145,7 +146,7 @@ class Server(private val transport: MessageTransport) : AutoCloseable {
|
||||
evaluator.close()
|
||||
|
||||
// close any running ExternalProcess instances for the closed evaluator
|
||||
externalReaderProcesses[message.evaluatorId]?.values?.forEach { it.close() }
|
||||
externalReaderProcesses.remove(message.evaluatorId)?.values?.forEach { it.close() }
|
||||
}
|
||||
|
||||
private fun buildDeclaredDependencies(
|
||||
|
||||
Reference in new issue
Block a user