starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-07-11 07:32:56 +02:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

Improve handling of evaluator in multi-file output (#1670)

Browse Source 
* Re-use same evaluator across output dirs
* Close evaluator after all files are written
This commit is contained in:
Daniel Chao
2026-06-10 06:52:47 -07:00
committed by GitHub
parent f6e3f5e00b
commit ac822f11eb
1 changed files with 34 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkl-cli/src/main/kotlin/org/pkl/cli/CliEvaluator.kt
+2 -1
View File
@@ -229,8 +229,8 @@ constructor(
private fun writeMultipleFileOutput(builder: EvaluatorBuilder) { private fun writeMultipleFileOutput(builder: EvaluatorBuilder) {
val outputDirs = directoryOutputPaths!! val outputDirs = directoryOutputPaths!!
val writtenFiles = mutableMapOf<Path, OutputFile>() val writtenFiles = mutableMapOf<Path, OutputFile>()
builder.setOutputFormat(options.outputFormat).build().use { evaluator ->
for ((moduleUri, outputDir) in outputDirs) { for ((moduleUri, outputDir) in outputDirs) {
val evaluator = builder.setOutputFormat(options.outputFormat).build()
if (outputDir.exists() && !outputDir.isDirectory()) { if (outputDir.exists() && !outputDir.isDirectory()) {
throw CliException("Output path `$outputDir` exists and is not a directory.") throw CliException("Output path `$outputDir` exists and is not a directory.")
} }
@@ -268,6 +268,7 @@ constructor(
} }
} }
} }
}
/** /**
* Resolves [rel] against this Path name-by-name. At each step, the real path is resolved if the * Resolves [rel] against this Path name-by-name. At each step, the real path is resolved if the