From 9046221e03f978c238a32625b7291d12ccbe9661 Mon Sep 17 00:00:00 2001 From: Daniel Chao Date: Mon, 20 Apr 2026 08:54:49 -0700 Subject: [PATCH] Fix dependency scopes (#1534) Fixes the following pom.xml issues: 1. pkl-doc and pkl-codegen-java sets the wrong dependency scopes for pkl-commons-cli/pkl-base 2. pkl-config-kotlin sets the wrong dependency scope for pkl-config-java-all Closes #1293 Closes #1517 --- pkl-codegen-java/pkl-codegen-java.gradle.kts | 4 ++-- pkl-config-kotlin/pkl-config-kotlin.gradle.kts | 2 +- pkl-doc/pkl-doc.gradle.kts | 6 ++++-- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/pkl-codegen-java/pkl-codegen-java.gradle.kts b/pkl-codegen-java/pkl-codegen-java.gradle.kts index 1a4f1b55..f8746eed 100644 --- a/pkl-codegen-java/pkl-codegen-java.gradle.kts +++ b/pkl-codegen-java/pkl-codegen-java.gradle.kts @@ -21,11 +21,11 @@ plugins { } dependencies { - // CliJavaCodeGeneratorOptions exposes CliBaseOptions + // CliJavaCodeGeneratorOptions exposes pkl-commons-cli and pkl-base api(projects.pklCommonsCli) + api(projects.pklCore) implementation(projects.pklCommons) - implementation(projects.pklCore) implementation(libs.javaPoet) testImplementation(projects.pklConfigJava) diff --git a/pkl-config-kotlin/pkl-config-kotlin.gradle.kts b/pkl-config-kotlin/pkl-config-kotlin.gradle.kts index 5177fd78..b9c4c876 100644 --- a/pkl-config-kotlin/pkl-config-kotlin.gradle.kts +++ b/pkl-config-kotlin/pkl-config-kotlin.gradle.kts @@ -101,7 +101,7 @@ publishing { appendNode("groupId", "org.pkl-lang") appendNode("artifactId", "pkl-config-java-all") appendNode("version", project.version) - appendNode("scope", "runtime") + appendNode("scope", "compile") } } } diff --git a/pkl-doc/pkl-doc.gradle.kts b/pkl-doc/pkl-doc.gradle.kts index 5bc0de8e..449d0c5e 100644 --- a/pkl-doc/pkl-doc.gradle.kts +++ b/pkl-doc/pkl-doc.gradle.kts @@ -33,8 +33,10 @@ executable { } dependencies { - implementation(projects.pklCore) - implementation(projects.pklCommonsCli) + // CliDocGeneratorOptions exposes pkl-commons-cli and pkl-base + api(projects.pklCore) + api(projects.pklCommonsCli) + implementation(projects.pklCommons) implementation(projects.pklParser) implementation(libs.commonMark)