starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-07-08 14:05:17 +02:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

Fix calls to string case api (#1620)

Browse Source 
* Enable IntelliJ inspection for calls to `String.toLowerCase()` and
`String.toUpperCase()`
* Enable error prone check
* Fix all issues
This commit is contained in:
Daniel Chao
2026-05-26 11:20:02 -07:00
committed by GitHub
parent d6f35dd49e
commit 72948e50fe
10 changed files with 22 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkl-core/src/main/java/org/pkl/core/ast/builder/AstBuilder.java
+2 -1
View File
@@ -27,6 +27,7 @@ import java.net.URISyntaxException;
import java.util.ArrayList;
import java.util.LinkedHashSet;
import java.util.List;
import java.util.Locale;
import java.util.Objects;
import java.util.Set;
import java.util.function.BiFunction;
@@ -2541,7 +2542,7 @@ public class AstBuilder extends AbstractAstBuilder<Object> {
int modifier = visitModifier(ctx);
if ((modifier & validModifiers) == 0) {
throw exceptionBuilder()
.evalError(errorMessage, ctx.getValue().name().toLowerCase())
.evalError(errorMessage, ctx.getValue().name().toLowerCase(Locale.ROOT))
.withSourceSection(createSourceSection(ctx))
.build();
}
pkl-core/src/main/java/org/pkl/core/evaluatorSettings/PklEvaluatorSettings.java
+3 -2
View File
@@ -22,6 +22,7 @@ import java.util.Collections;
import java.util.HashMap;
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Locale;
import java.util.Map;
import java.util.Map.Entry;
import java.util.Objects;
@@ -115,7 +116,7 @@ public record PklEvaluatorSettings(
(Map<String, String>) pSettings.get("env"),
allowedModules,
allowedResources,
color == null ? null : Color.valueOf(color.toUpperCase()),
color == null ? null : Color.valueOf(color.toUpperCase(Locale.ROOT)),
(Boolean) pSettings.get("noCache"),
moduleCacheDir,
modulePath,
@@ -124,7 +125,7 @@ public record PklEvaluatorSettings(
Http.parse((Value) pSettings.get("http")),
externalModuleReaders,
externalResourceReaders,
traceMode == null ? null : TraceMode.valueOf(traceMode.toUpperCase()));
traceMode == null ? null : TraceMode.valueOf(traceMode.toUpperCase(Locale.ROOT)));
}
public record Http(
pkl-core/src/main/java/org/pkl/core/runtime/CommandSpecParser.java
+2 -1
View File
@@ -27,6 +27,7 @@ import java.nio.file.Path;
import java.util.ArrayList;
import java.util.HashSet;
import java.util.List;
import java.util.Locale;
import java.util.Map;
import java.util.Set;
import java.util.function.BiFunction;
@@ -737,7 +738,7 @@ public final class CommandSpecParser {
if (each == null)
each =
(rawValue, workingDirUri) -> {
var value = rawValue.toLowerCase();
var value = rawValue.toLowerCase(Locale.ROOT);
if (TRUE_VALUES.contains(value)) {
return true;
} else if (FALSE_VALUES.contains(value)) {
pkl-core/src/main/java/org/pkl/core/util/IoUtils.java
+2 -2
View File
@@ -889,7 +889,7 @@ public final class IoUtils {
}
private static boolean isReservedHeaderName(String headerName) {
var normalizedHeader = headerName.toLowerCase();
var normalizedHeader = headerName.toLowerCase(Locale.ROOT);
for (var reservedHeader : reservedHeaderNames) {
if (normalizedHeader.equals(reservedHeader)) {
return true;
@@ -899,7 +899,7 @@ public final class IoUtils {
}
private static boolean hasReservedHeaderPrefix(String headerName) {
var normalizedHeader = headerName.toLowerCase();
var normalizedHeader = headerName.toLowerCase(Locale.ROOT);
for (var prefix : reservedHeaderPrefixes) {
if (normalizedHeader.startsWith(prefix)) {
return true;