starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-05-17 12:27:04 +02:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

Fix NPE when handling ExternalReader specs with null arguments (#882)

Browse Source
This commit is contained in:
Josh B
2025-01-14 04:51:09 -08:00
committed by Daniel Chao
parent 0bc1b7156e
commit 6c8e45b19a
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkl-core/src/main/java/org/pkl/core/externalreader/ExternalReaderProcessImpl.java
+4 -2
View File
@@ -1,5 +1,5 @@
/* /*
* Copyright © 2024 Apple Inc. and the Pkl project authors. All rights reserved. * Copyright © 2024-2025 Apple Inc. and the Pkl project authors. All rights reserved.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@@ -107,7 +107,9 @@ final class ExternalReaderProcessImpl implements ExternalReaderProcess {
// This relies on Java/OS behavior around PATH resolution, absolute/relative paths, etc. // This relies on Java/OS behavior around PATH resolution, absolute/relative paths, etc.
var command = new ArrayList<String>(); var command = new ArrayList<String>();
command.add(spec.executable()); command.add(spec.executable());
command.addAll(spec.arguments()); if (spec.arguments() != null) {
command.addAll(spec.arguments());
}
var builder = new ProcessBuilder(command); var builder = new ProcessBuilder(command);
builder.redirectError(Redirect.INHERIT); // inherit stderr from this pkl process builder.redirectError(Redirect.INHERIT); // inherit stderr from this pkl process