starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-06-05 21:32:45 +02:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

Improve error message when parsing truncated let expressions (#1639)

Browse Source 
This previously yielded
```
Unexpected token `}`. Expected `}`.
```
Pretty confusing, no?

Now it's just
```
Unexpected token `}`.
```

Resolves #1638
This commit is contained in:
Jen Basch
2026-06-02 16:00:46 -07:00
committed by GitHub
parent 99cac1f886
commit 68f7d06eed
5 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkl-parser/src/main/java/org/pkl/parser/GenericParserImpl.java
+1 -1
View File
@@ -888,7 +888,7 @@ class GenericParserImpl {
expect(Token.RPAREN, paramDef, "unexpectedToken", ")");
children.add(new Node(NodeType.LET_PARAMETER_DEFINITION, paramDef));
ff(children);
children.add(parseExpr(expectation));
children.add(parseExpr());
yield new Node(NodeType.LET_EXPR, children);
}
case TRUE, FALSE -> new Node(NodeType.BOOL_LITERAL_EXPR, next().span);
pkl-parser/src/main/java/org/pkl/parser/ParserImpl.java
+1 -1
View File
@@ -1009,7 +1009,7 @@ final class ParserImpl {
expect(Token.ASSIGN, "unexpectedToken", "=");
var bindExpr = parseExpr(")");
expect(Token.RPAREN, "unexpectedToken", ")");
var exp = parseExpr(expectation);
var exp = parseExpr();
yield new LetExpr(param, bindExpr, exp, start.endWith(exp.span()));
}
case TRUE -> new BoolLiteralExpr(true, next().span);
pkl-parser/src/test/kotlin/org/pkl/parser/ParserComparisonTest.kt
+1
View File
@@ -99,6 +99,7 @@ class ParserComparisonTest {
"errors/invalidCharacterEscape.pkl",
"errors/invalidCharacterEscape2.pkl",
"errors/invalidUnicodeEscape.pkl",
"errors/letExpressionError3.pkl",
"errors/unterminatedUnicodeEscape.pkl",
"errors/keywordNotAllowedHere1.pkl",
"errors/keywordNotAllowedHere2.pkl",