Fix stream double-consumption in CommandSpecParser (#1448)

The `choices` stream was consumed eagerly for metavar construction, then
captured in a lambda for later validation—which promptly fell over with
`IllegalStateException`. Materialise to a `List` straightaway.
This commit is contained in:
Kushal Pisavadia
2026-02-27 10:04:32 +00:00
committed by GitHub
parent cac3e483b5
commit 64ea7951db
2 changed files with 30 additions and 4 deletions
@@ -787,4 +787,31 @@ class CommandSpecParserTest {
.contains("Option `foo` with annotation `@CountedFlag` has invalid type `String`.")
assertThat(exc.message).contains("Expected type: `Int`")
}
@Test
fun `union typed option validates invalid choice without stream error`() {
val moduleUri =
writePklFile(
"cmd.pkl",
renderOptions +
"""
class Options {
format: "json" | "yaml" | "toml"
}
"""
.trimIndent(),
)
val spec = parse(moduleUri)
val flag = spec.options.first() as CommandSpec.Flag
assertThat(flag.metavar()).isEqualTo("[json, toml, yaml]")
val apply =
assertThrows<CommandSpec.Option.BadValue> {
flag.transformEach().apply("xml", URI("file:///tmp"))
}
assertThat(apply.message).contains("invalid choice")
assertThat(apply.message).contains("xml")
}
}