From 5510bf12d2476188e665e089100032a2558171cf Mon Sep 17 00:00:00 2001 From: translatenix <119817707+translatenix@users.noreply.github.com> Date: Wed, 17 Apr 2024 16:37:55 -0700 Subject: [PATCH] Eliminate redundant map lookup (#433) --- .../core/ast/expression/generator/GeneratorSpreadNode.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pkl-core/src/main/java/org/pkl/core/ast/expression/generator/GeneratorSpreadNode.java b/pkl-core/src/main/java/org/pkl/core/ast/expression/generator/GeneratorSpreadNode.java index 4fda8573..4aec10f9 100644 --- a/pkl-core/src/main/java/org/pkl/core/ast/expression/generator/GeneratorSpreadNode.java +++ b/pkl-core/src/main/java/org/pkl/core/ast/expression/generator/GeneratorSpreadNode.java @@ -346,7 +346,8 @@ public abstract class GeneratorSpreadNode extends GeneratorMemberNode { if (member.isLocal()) return; var memberName = member.getName(); - if (!clazz.hasProperty(memberName)) { + var classProperty = clazz.getProperty(memberName); + if (classProperty == null) { CompilerDirectives.transferToInterpreter(); var exception = exceptionBuilder() @@ -362,8 +363,7 @@ public abstract class GeneratorSpreadNode extends GeneratorMemberNode { throw exception; } - var classProperty = clazz.getProperty(memberName); - if (classProperty != null && classProperty.isConstOrFixed()) { + if (classProperty.isConstOrFixed()) { CompilerDirectives.transferToInterpreter(); var errMsg = classProperty.isConst() ? "cannotAssignConstProperty" : "cannotAssignFixedProperty";