starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-06-12 16:44:33 +02:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

Exclude non-ascii files from windows native snippet tests (#739)

Browse Source 
There is an existing bug that is preventing the CLI from loading
these files.
This commit is contained in:
Daniel Chao
2024-10-26 07:56:00 -07:00
committed by GitHub
parent 08be6be059
commit 466ae6fd4c
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkl-core/src/test/kotlin/org/pkl/core/LanguageSnippetTestsEngine.kt
+10 -2
View File
@@ -309,12 +309,20 @@ private val windowsExcludedTests
// error message contains different file path on Windows // error message contains different file path on Windows
Regex(".*missingProjectDeps/bug\\.pkl"), Regex(".*missingProjectDeps/bug\\.pkl"),
// URIs get rendered slightly differently (percent-encoded vs raw) // URIs get rendered slightly differently (percent-encoded vs raw)
Regex(".*日本語_error\\.pkl") Regex(".*日本語_error\\.pkl"),
)
private val windowsNativeExcludedTests
get() =
listOf(
// CLI args on Windows turn into `?` when in native image
// https://github.com/oracle/graal/issues/8593
Regex(".*日本語\\.pkl")
) )
class WindowsLanguageSnippetTestsEngine : AbstractNativeLanguageSnippetTestsEngine() { class WindowsLanguageSnippetTestsEngine : AbstractNativeLanguageSnippetTestsEngine() {
override val pklExecutablePath: Path = PklExecutablePaths.windowsAmd64 override val pklExecutablePath: Path = PklExecutablePaths.windowsAmd64
override val testClass: KClass<*> = WindowsLanguageSnippetTests::class override val testClass: KClass<*> = WindowsLanguageSnippetTests::class
override val excludedTests: List<Regex> override val excludedTests: List<Regex>
get() = super.excludedTests + windowsExcludedTests get() = super.excludedTests + windowsNativeExcludedTests + windowsExcludedTests
} }