starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-04-25 01:38:34 +02:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

Convert org.pkl.core.runtime POJOs to record classes (#807)

Browse Source
This commit is contained in:
Kushal Pisavadia
2024-11-13 13:09:21 +00:00
committed by GitHub
parent dddbb27143
commit 3f91824dc2
3 changed files with 5 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
pkl-core/src/main/java/org/pkl/core/runtime/StackTraceRenderer.java
View File

@@ -131,15 +131,7 @@ public final class StackTraceRenderer {
* former is public API and the latter isn't. * former is public API and the latter isn't.
*/ */
// non-private for testing // non-private for testing
static class StackFrameLoop { record StackFrameLoop(List<Object /*StackFrame|StackFrameLoop*/> frames, int count) {}
final List<Object /*StackFrame|StackFrameLoop*/> frames;
final int count;
StackFrameLoop(List<Object> frames, int count) {
this.count = count;
this.frames = frames;
}
}
// non-private for testing // non-private for testing
static List<Object /*StackFrame|StackFrameLoop*/> compressFrames(List<StackFrame> frames) { static List<Object /*StackFrame|StackFrameLoop*/> compressFrames(List<StackFrame> frames) {

10
pkl-core/src/main/java/org/pkl/core/runtime/VmException.java
View File

@@ -98,17 +98,9 @@ public abstract class VmException extends AbstractTruffleException {
BUG BUG
} }
public static final class ProgramValue { public record ProgramValue(String name, Object value) {
private static final VmValueRenderer valueRenderer = VmValueRenderer.singleLine(80); private static final VmValueRenderer valueRenderer = VmValueRenderer.singleLine(80);
public final String name;
public final Object value;
public ProgramValue(String name, Object value) {
this.name = name;
this.value = value;
}
@Override @Override
@TruffleBoundary @TruffleBoundary
public String toString() { public String toString() {

6
pkl-core/src/main/java/org/pkl/core/runtime/VmExceptionRenderer.java
View File

@@ -112,11 +112,11 @@ public final class VmExceptionRenderer {
} }
var maxNameLength = var maxNameLength =
exception.getProgramValues().stream().mapToInt(v -> v.name.length()).max().orElse(0); exception.getProgramValues().stream().mapToInt(v -> v.name().length()).max().orElse(0);
for (var value : exception.getProgramValues()) { for (var value : exception.getProgramValues()) {
out.append(value.name) out.append(value.name())
.append(" ".repeat(Math.max(0, maxNameLength - value.name.length()))) .append(" ".repeat(Math.max(0, maxNameLength - value.name().length())))
.append(": ") .append(": ")
.append(value) .append(value)
.append('\n'); .append('\n');