mirror of
https://github.com/apple/pkl.git
synced 2026-06-25 06:46:18 +02:00
Revert "Reject abstract members in non-abstract classes" (#1688)
The changes made in this commit are good, but we're going to kick this out to the next release. This is because: 1. There's a couple more issues around the `abstract` modifier that is not implemented yet, and need design considerations 2. These are breaking changes, and we want to minimize the amount of breakages for users. 3. The main branch is still the develop branch for Pkl 0.32 We will apply a re-revert of this commit after Pkl 0.32 is released.
This commit is contained in:
+1
-1
@@ -1,5 +1,5 @@
|
||||
/// Module methods with different modifiers.
|
||||
abstract module com.package1.moduleMethodModifiers
|
||||
module com.package1.moduleMethodModifiers
|
||||
|
||||
/// Method with `abstract` modifier.
|
||||
abstract function method1(arg: String): Boolean
|
||||
|
||||
+1
-1
@@ -32,7 +32,7 @@
|
||||
</ul>
|
||||
<div id="_overview" class="anchor"> </div>
|
||||
<div id="_declaration" class="member">
|
||||
<div class="member-signature">abstract module <span class="name-decl">com.package1.moduleMethodModifiers</span></div>
|
||||
<div class="member-signature">module <span class="name-decl">com.package1.moduleMethodModifiers</span></div>
|
||||
<div class="doc-comment"><p>Module methods with different modifiers.</p></div>
|
||||
<dl class="member-info">
|
||||
<dt class="">Module URI:</dt>
|
||||
|
||||
+1
-1
@@ -32,7 +32,7 @@
|
||||
</ul>
|
||||
<div id="_overview" class="anchor"> </div>
|
||||
<div id="_declaration" class="member">
|
||||
<div class="member-signature">abstract module <span class="name-decl">com.package1.moduleMethodModifiers</span></div>
|
||||
<div class="member-signature">module <span class="name-decl">com.package1.moduleMethodModifiers</span></div>
|
||||
<div class="doc-comment"><p>Module methods with different modifiers.</p></div>
|
||||
<dl class="member-info">
|
||||
<dt class="">Module URI:</dt>
|
||||
|
||||
Reference in New Issue
Block a user