starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-08-29 15:07:17 +02:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

Improve reading of const members (#1835)

Browse Source 
The previous implementation can cause the JIT compiler to permanently
bail out when reading const memebrs.
This commit is contained in:
Daniel Chao
2026-08-28 09:18:56 -07:00
committed by GitHub
parent 1cfdd3d30d
commit 1208fa9438
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkl-core/src/main/java/org/pkl/core/runtime/VmUtils.java
+9 -2
View File
@@ -353,9 +353,16 @@ public final class VmUtils {
// can be re-used for all children in the amends chain. // can be re-used for all children in the amends chain.
if (member.isConst() && owner != receiver) { if (member.isConst() && owner != receiver) {
assert member.isProp(); assert member.isProp();
// `const` properties can possibly be declared on non-prototypes, but they must be also
// declared `local`; and that code path goes through `Read*LocalPropertyNode`.
// thus, this assertion is correct here.
assert owner.isPrototype(); assert owner.isPrototype();
var result = readMemberOrNull(owner, memberKey, checkType, callNode); var cachedValue = owner.getCachedValue(memberKey);
assert result != null; if (cachedValue != null) {
receiver.setCachedValue(memberKey, cachedValue);
return cachedValue;
}
var result = doReadMember(owner, owner, memberKey, member, checkType, callNode);
receiver.setCachedValue(memberKey, result); receiver.setCachedValue(memberKey, result);
return result; return result;
} }