Add color to error formatting (#746)

* Add color to error formatting

* Apply suggestions from code review

Co-authored-by: Daniel Chao <daniel.h.chao@gmail.com>

* Address reviewer comments

* Apply suggestions from code review

Co-authored-by: Daniel Chao <daniel.h.chao@gmail.com>

* Define style choices as operations on formatter (abandon semantic API)

* Adjust margin styling

* Review feedback

* Documentation nits

---------

Co-authored-by: Daniel Chao <daniel.h.chao@gmail.com>
This commit is contained in:
Philip K.F. HölzenspiesandDaniel Chao authored and GitHub committed 2024-11-01 10:02:19 +00:00
1 parent e217cfcd6f
commit 03462fefae
38 files changed
+445 -114

No files matched your search

@@ -120,7 +120,7 @@ constructor(
try {
moduleResolver.resolve(uri)
} catch (e: VmException) {
throw e.toPklException(stackFrameTransformer)
throw e.toPklException(stackFrameTransformer, options.base.color?.hasColor() ?: false)
}
val substituted =
pathStr
@@ -81,6 +81,7 @@ class CliProjectPackager(
cliOptions.normalizedWorkingDir,
outputPath,
stackFrameTransformer,
cliOptions.color?.hasColor() ?: false,
securityManager,
httpClient,
skipPublishCheck,
@@ -66,7 +66,8 @@ internal class CliRepl(private val options: CliEvaluatorOptions) : CliCommand(op
project?.dependencies,
options.outputFormat,
options.base.normalizedWorkingDir,
stackFrameTransformer
stackFrameTransformer,
options.base.color?.hasColor() ?: false,
)
Repl(options.base.normalizedWorkingDir, server).run()
}
@@ -41,7 +41,8 @@ class ReplMessagesTest {
null,
null,
"/".toPath(),
StackFrameTransformers.defaultTransformer
StackFrameTransformers.defaultTransformer,
false,
)
@Test