From d27818e948619db304702bb5c1813c9d1b16ba92 Mon Sep 17 00:00:00 2001 From: Ryan Yin Date: Fri, 2 Oct 2026 23:50:08 +0800 Subject: [PATCH] docs: update stale workaround comments - wechat.nix: repacking is needed because nixpkgs' wechat package does not expose its AppImage wrapper args for `.override`, not because wrapAppImage lacks overriding (it forwards args to buildFHSEnv). - peripherals.nix: drop a link to an already-closed issue and fix a typo. --- hardening/bwraps/wechat.nix | 4 +++- modules/nixos/desktop/peripherals.nix | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hardening/bwraps/wechat.nix b/hardening/bwraps/wechat.nix index b24111c9..a0a5dc27 100644 --- a/hardening/bwraps/wechat.nix +++ b/hardening/bwraps/wechat.nix @@ -4,7 +4,9 @@ # - https://docs.flatpak.org/en/latest/manifests.html # - https://docs.flatpak.org/en/latest/sandbox-permissions.html # -# TODO Since appimageTools.wrapAppImage do not support overriding, I have to pack this package myself. +# TODO nixpkgs' `wechat` package hardcodes its AppImage wrapper args and does not +# expose them for `.override`, so we repack it here to add our bubblewrap sandbox +# (bind mounts, tmpfs /home, IME env). Upstream override support: # https://github.com/NixOS/nixpkgs/pull/358977 { appimageTools, diff --git a/modules/nixos/desktop/peripherals.nix b/modules/nixos/desktop/peripherals.nix index ae9db234..d5a4fde3 100644 --- a/modules/nixos/desktop/peripherals.nix +++ b/modules/nixos/desktop/peripherals.nix @@ -53,7 +53,7 @@ udev.packages = with pkgs; [ gnome-settings-daemon # platformio # udev rules for platformio - # openocd # required by paltformio, see https://github.com/NixOS/nixpkgs/issues/224895 + # openocd # platformio needs these udev rules for rootless USB access # openfpgaloader ];