From 0030a41a8fcd3a6a7a0b3d87fb745440a215ae54 Mon Sep 17 00:00:00 2001
From: Ryan Yin <xiaoyin_c@qq.com>
Date: Mon, 31 Jul 2023 10:52:43 +0800
Subject: [PATCH] feat: install jdk17(Adoptium prebuilt jdk on macOS)

---
 home/base/desktop/development.nix | 3 ++-
 modules/darwin/apps.nix           | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/home/base/desktop/development.nix b/home/base/desktop/development.nix
index 5471478d..38adf6db 100644
--- a/home/base/desktop/development.nix
+++ b/home/base/desktop/development.nix
@@ -34,8 +34,9 @@
     aws-iam-authenticator
     eksctl
 
-    # DO NOT install build tools for C/C++, set it per project by devShell instead
+    # DO NOT install build tools for C/C++ and others, set it per project by devShell instead
     gnumake # used by this repo, to simplify the deployment
+    jdk17   # used to run some java based tools(.jar)
 
     # python
     (python311.withPackages (ps:
diff --git a/modules/darwin/apps.nix b/modules/darwin/apps.nix
index 8669983f..af3818be 100644
--- a/modules/darwin/apps.nix
+++ b/modules/darwin/apps.nix
@@ -122,6 +122,7 @@
       # Development
       "insomnia" # REST client
       "wireshark" # network analyzer
+      "temurin17"  # JDK 17
       "jdk-mission-control" # Java Mission Control
       "google-cloud-sdk" # Google Cloud SDK
     ];