From e401a75ca5cd77b6d74f3e0b9a0640f17b6e3b0c Mon Sep 17 00:00:00 2001 From: Ryan Yin Date: Fri, 25 Sep 2026 00:29:39 +0800 Subject: [PATCH] chore(agents): remove crush Crush hardcodes banned bash commands, blocking many operations. Drop the package, its AGENTS.md/CRUSH.md install target, env vars, and preservation entries. --- agents/README.md | 1 - agents/install-cli.md | 1 - agents/install-rules.py | 2 -- agents/test_install_rules.py | 7 +++---- home/base/gui/dev-tools.nix | 1 - home/base/tui/agent-env.nix | 3 --- hosts/idols-ai/preservation.nix | 2 -- hosts/idols-ruby/packages.nix | 1 - 8 files changed, 3 insertions(+), 15 deletions(-) diff --git a/agents/README.md b/agents/README.md index a12487cc..99d0eb51 100644 --- a/agents/README.md +++ b/agents/README.md @@ -35,7 +35,6 @@ Current targets: - OpenCode: `AGENTS.md` -> `${XDG_CONFIG_HOME:-~/.config}/opencode/AGENTS.md` - Pi: `AGENTS.md` -> `~/.pi/agent/AGENTS.md` - OMP: `AGENTS.md` -> `~/.omp/agent/AGENTS.md` -- Crush: `AGENTS.md` -> `${XDG_CONFIG_HOME:-~/.config}/crush/CRUSH.md` - Generic cross-tool (read by Kimi Code): `AGENTS.md` -> `~/.agents/AGENTS.md` Behavior: diff --git a/agents/install-cli.md b/agents/install-cli.md index da7a7db2..a7cfdba0 100644 --- a/agents/install-cli.md +++ b/agents/install-cli.md @@ -11,7 +11,6 @@ Installed via Nix: - kimi-code - pi - omp -- crush ## Optional tooling diff --git a/agents/install-rules.py b/agents/install-rules.py index 912a5e35..2f7ab317 100644 --- a/agents/install-rules.py +++ b/agents/install-rules.py @@ -47,14 +47,12 @@ def main() -> int: opencode_dir = xdg_config_home / "opencode" pi_dir = Path("~/.pi/agent").expanduser() omp_dir = Path("~/.omp/agent").expanduser() - crush_dir = xdg_config_home / "crush" agents_dir = Path("~/.agents").expanduser() targets = ( (codex_dir, "AGENTS.md"), (opencode_dir, "AGENTS.md"), (pi_dir, "AGENTS.md"), (omp_dir, "AGENTS.md"), - (crush_dir, "CRUSH.md"), (agents_dir, "AGENTS.md"), ) failed = False diff --git a/agents/test_install_rules.py b/agents/test_install_rules.py index b1c54df6..956816e9 100644 --- a/agents/test_install_rules.py +++ b/agents/test_install_rules.py @@ -23,7 +23,6 @@ class InstallRulesTests(unittest.TestCase): (home / ".config" / "opencode", "AGENTS.md"), (home / ".pi" / "agent", "AGENTS.md"), (home / ".omp" / "agent", "AGENTS.md"), - (home / ".config" / "crush", "CRUSH.md"), (home / ".agents", "AGENTS.md"), ) for target_dir, _ in target_names: @@ -42,18 +41,18 @@ class InstallRulesTests(unittest.TestCase): patch.object( installer, "install_one", - side_effect=[PermissionError("denied"), None, None, None, None, None], + side_effect=[PermissionError("denied"), None, None, None, None], ) as install, patch("sys.stderr", new_callable=io.StringIO) as stderr, ): self.assertEqual(installer.main(), 1) - self.assertEqual(install.call_count, 6) + self.assertEqual(install.call_count, 5) self.assertIn("denied", stderr.getvalue()) def test_successful_targets_return_success(self): with patch.object(installer, "install_one") as install: self.assertEqual(installer.main(), 0) - self.assertEqual(install.call_count, 6) + self.assertEqual(install.call_count, 5) def test_existing_file_is_backed_up_without_overwriting_backup(self): with tempfile.TemporaryDirectory() as directory: diff --git a/home/base/gui/dev-tools.nix b/home/base/gui/dev-tools.nix index 012ccb77..f09eebfd 100644 --- a/home/base/gui/dev-tools.nix +++ b/home/base/gui/dev-tools.nix @@ -27,6 +27,5 @@ in agentPackages.kimi-code agentPackages.pi agentPackages.omp - agentPackages.crush ]; } diff --git a/home/base/tui/agent-env.nix b/home/base/tui/agent-env.nix index 84de98be..129df248 100644 --- a/home/base/tui/agent-env.nix +++ b/home/base/tui/agent-env.nix @@ -5,9 +5,6 @@ PI_TELEMETRY = "0"; PI_SKIP_VERSION_CHECK = "1"; - CRUSH_DISABLE_METRICS = "1"; - CRUSH_DISABLE_PROVIDER_AUTO_UPDATE = "1"; - OPENCODE_DISABLE_AUTOUPDATE = "1"; }; diff --git a/hosts/idols-ai/preservation.nix b/hosts/idols-ai/preservation.nix index 5257adb9..cfc5f147 100644 --- a/hosts/idols-ai/preservation.nix +++ b/hosts/idols-ai/preservation.nix @@ -159,8 +159,6 @@ in ".config/opencode" ".local/share/opencode" ".local/state/opencode" - ".config/crush" - ".local/share/crush" # herdr: plugin registry, plugin checkouts/config, session layout ".config/herdr" diff --git a/hosts/idols-ruby/packages.nix b/hosts/idols-ruby/packages.nix index 6e1bff21..a2e0f1cd 100644 --- a/hosts/idols-ruby/packages.nix +++ b/hosts/idols-ruby/packages.nix @@ -88,6 +88,5 @@ in agentPackages.kimi-code agentPackages.pi agentPackages.omp - agentPackages.crush ]; }