starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Filter reset button does not reset filter #9998

New Issue
Closed
opened 2025-12-29 21:25:26 +01:00 by adam · 1 comment
adam commented 2025-12-29 21:25:26 +01:00
Owner
Copy Link

Originally created by @mhdask on GitHub (Jul 23, 2024).

Originally assigned to: @arthanson on GitHub.

Deployment Type

Self-hosted

NetBox Version

v4.0.7

Python Version

3.10

Steps to Reproduce

  1. Click on Devices (I think any model that can be filtered will do)
  2. Click on filter
  3. Apply any filter (I used Status PLANNED for device)
  4. Press Reset
  5. Observe filter is still applied

Expected Behavior

The filter should have been removed / reset

Observed Behavior

The filter did not get removed / reset

Originally created by @mhdask on GitHub (Jul 23, 2024). Originally assigned to: @arthanson on GitHub. ### Deployment Type Self-hosted ### NetBox Version v4.0.7 ### Python Version 3.10 ### Steps to Reproduce 1. Click on Devices (I think any model that can be filtered will do) 2. Click on filter 3. Apply any filter (I used Status PLANNED for device) 4. Press Reset 5. Observe filter is still applied ### Expected Behavior The filter should have been removed / reset ### Observed Behavior The filter did not get removed / reset
adam added the type: bugstatus: acceptedseverity: low labels 2025-12-29 21:25:26 +01:00
adam closed this issue 2025-12-29 21:25:26 +01:00
adam commented 2025-12-29 21:25:27 +01:00
Author
Owner
Copy Link

@arthanson commented on GitHub (Jul 29, 2024):

It looks like this routine:

  /**
   * Initialize any adjacent reset buttons so that when clicked, the page is reloaded without
   * query parameters.
   */
  private initResetButton(): void {
    const resetButton = findFirstAdjacent<HTMLButtonElement>(
      this.base,
      'button[data-reset-select]',
    );
    if (resetButton !== null) {
      resetButton.addEventListener('click', () => {
        window.location.assign(window.location.origin + window.location.pathname);
      });
    }
  }

from the old apiSelect.ts is missing.

@arthanson commented on GitHub (Jul 29, 2024): It looks like this routine: ``` /** * Initialize any adjacent reset buttons so that when clicked, the page is reloaded without * query parameters. */ private initResetButton(): void { const resetButton = findFirstAdjacent<HTMLButtonElement>( this.base, 'button[data-reset-select]', ); if (resetButton !== null) { resetButton.addEventListener('click', () => { window.location.assign(window.location.origin + window.location.pathname); }); } } ``` from the old apiSelect.ts is missing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label severity: low status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#9998
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?