starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Escape config-revision banner values by default #9992

New Issue
Closed
opened 2025-12-29 21:25:22 +01:00 by adam · 2 comments
adam commented 2025-12-29 21:25:22 +01:00
Owner
Copy Link

Originally created by @jeffgdotorg on GitHub (Jul 17, 2024).

NetBox version

v4.0.7

Feature type

Change to existing functionality

Proposed functionality

  • The values of the banner fields (login, maintenance, top, bottom) are escaped by default before displaying
    • Nice to have / bonus: Banners support Markdown rendering
  • A new configuration parameter, e.g. ESCAPE_BANNERS, is available and can be set to False to override the default behavior
  • Configuration Documentation updated to mention this new configuration parameter
  • Names of all dependent objects are escaped before displaying in error messages when parent object deletion fails

Use case

  • Our users trust NetBox to be a safe and secure place to store sensitive information about the actual and intended state of their networks
  • Many users need to include formatting, hyperlinks, or even arbitrary markup in the values of their system banners.
  • All users benefit from a system whose security posture defaults to protecting them from malicious content, which threat actors are very good at finding ways to inject

Database changes

None

External dependencies

None

Originally created by @jeffgdotorg on GitHub (Jul 17, 2024). ### NetBox version v4.0.7 ### Feature type Change to existing functionality ### Proposed functionality - The values of the banner fields (login, maintenance, top, bottom) are escaped by default before displaying - Nice to have / bonus: Banners support Markdown rendering - A new configuration parameter, e.g. `ESCAPE_BANNERS`, is available and can be set to `False` to override the default behavior - Configuration Documentation updated to mention this new configuration parameter - Names of all dependent objects are escaped before displaying in error messages when parent object deletion fails ### Use case - Our users trust NetBox to be a safe and secure place to store sensitive information about the actual and intended state of their networks - Many users need to include formatting, hyperlinks, or even arbitrary markup in the values of their system banners. - All users benefit from a system whose security posture defaults to protecting them from malicious content, which threat actors are very good at finding ways to inject ### Database changes None ### External dependencies None
adam added the type: feature label 2025-12-29 21:25:22 +01:00
adam closed this issue 2025-12-29 21:25:22 +01:00
adam commented 2025-12-29 21:25:22 +01:00
Author
Owner
Copy Link

@minhquan202 commented on GitHub (Jul 18, 2024):

no bro, not fix

@minhquan202 commented on GitHub (Jul 18, 2024): no bro, not fix
adam commented 2025-12-29 21:25:22 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Jul 25, 2024):

As has been discussed in previous conversations, these banners are intended to support raw HTML. Users do not have permission to set any of this content by default; only administrators may modify the content. This change is not needed.

@jeremystretch commented on GitHub (Jul 25, 2024): As has been discussed in previous conversations, these banners are intended to support raw HTML. Users do not have permission to set any of this content by default; only administrators may modify the content. This change is not needed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#9992
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?