starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Import Devices allows overlapping rack positions instead of erroring #999

New Issue
Closed
opened 2025-12-29 16:27:41 +01:00 by adam · 2 comments
adam commented 2025-12-29 16:27:41 +01:00
Owner
Copy Link

Originally created by @HumanEquivalentUnit on GitHub (May 26, 2017).

Issue type: bug report

Python version: 2.7.5 (CentOS 7 default)
NetBox version: 2.0.3

  • I configured a device type (HP ProLiant Server) as a 2U device.
  • Imported devices, entered three lines of CSV data, putting them in rack positions 17, 16, 15 (clash!)
  • The import succeeded without errors, and then looking at the rack nothing was rendered in those U positions at all - the imported devices were invisible.

This was a mistake, the servers are actually 1U, and I corrected the device type to 1U and that fixed it, they rendered in the right places.

Expectation: the import would fail because the devices would overlap with each other. Or the rack would render with an error visible in the double-assigned U positions.

Originally created by @HumanEquivalentUnit on GitHub (May 26, 2017). <!-- Please note: GitHub issues are to be used only for feature requests and bug reports. For installation assistance or general discussion, please join us on the mailing list: https://groups.google.com/forum/#!forum/netbox-discuss Please indicate "bug report" or "feature request" below. Be sure to search the existing set of issues (both open and closed) to see if a similar issue has already been raised. --> ### Issue type: bug report <!-- If filing a bug, please indicate the version of Python and NetBox you are running. (This is not necessary for feature requests.) --> **Python version: 2.7.5 (CentOS 7 default)** **NetBox version: 2.0.3** <!-- If filing a bug, please record the exact steps taken to reproduce the bug and any errors messages that are generated. If filing a feature request, please precisely describe the data model or workflow you would like to see implemented, and provide a use case. --> - I configured a device type (HP ProLiant Server) as a 2U device. - Imported devices, entered three lines of CSV data, putting them in rack positions 17, 16, 15 (clash!) - The import succeeded without errors, and then looking at the rack nothing was rendered in those U positions at all - the imported devices were invisible. This was a mistake, the servers are actually 1U, and I corrected the device type to 1U and that fixed it, they rendered in the right places. Expectation: the import would fail because the devices would overlap with each other. Or the rack would render with an error visible in the double-assigned U positions.
adam added the type: bug label 2025-12-29 16:27:41 +01:00
adam closed this issue 2025-12-29 16:27:41 +01:00
adam commented 2025-12-29 16:27:42 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (May 31, 2017):

This is occurring because validation is being performed on each imported device in bulk before the devices are actually created. The bulk import logic is being overwritten in #655, which should resolve this bug once it's completed. Leaving this open for reference.

@jeremystretch commented on GitHub (May 31, 2017): This is occurring because validation is being performed on each imported device in bulk _before_ the devices are actually created. The bulk import logic is being overwritten in #655, which should resolve this bug once it's completed. Leaving this open for reference.
adam commented 2025-12-29 16:27:42 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Jun 7, 2017):

This should no longer happen with the new per-object validation implemented as part of #655.

@jeremystretch commented on GitHub (Jun 7, 2017): This should no longer happen with the new per-object validation implemented as part of #655.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#999
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?