starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Errant or missing aria labels #9958

New Issue
Open
opened 2025-12-29 21:24:57 +01:00 by adam · 5 comments
adam commented 2025-12-29 21:24:57 +01:00
Owner
Copy Link

Originally created by @andrewgormley on GitHub (Jul 8, 2024).

NetBox version

v4.1.0-dev

Feature type

Change to existing functionality

Proposed functionality

  • (Add token) Broken aria references [Multiple]
  • (Tables) Missing aria label on quick search box [Multiple]
  • (Progress bars) Do not have accessible aria labels [Multiple]
  • (New object) aria broken on slug combo box [Multiple]
  • (New object) aria broken on input description text [Multiple]
  • (Misc) Form elements without effective labels [Multiple]

Use case

Fixing web accessibility issues ensures NetBox is best placed to serve users using screen readers and other accessibility tools.

Database changes

No response

External dependencies

No response

Originally created by @andrewgormley on GitHub (Jul 8, 2024). ### NetBox version v4.1.0-dev ### Feature type Change to existing functionality ### Proposed functionality - [ ] (Add token) Broken aria references [Multiple] - [ ] (Tables) Missing aria label on quick search box [Multiple] - [ ] (Progress bars) Do not have accessible aria labels [Multiple] - [ ] (New object) aria broken on slug combo box [Multiple] - [ ] (New object) aria broken on input description text [Multiple] - [ ] (Misc) Form elements without effective labels [Multiple] ### Use case Fixing web accessibility issues ensures NetBox is best placed to serve users using screen readers and other accessibility tools. ### Database changes _No response_ ### External dependencies _No response_
adam added the type: featurenetboxstatus: backlogtopic: UI/UXcomplexity: low labels 2025-12-29 21:24:57 +01:00
adam commented 2025-12-29 21:24:58 +01:00
Author
Owner
Copy Link

@andrewgormley commented on GitHub (Jul 24, 2024):

Similar to the table issues, all of these issues stem from form elements which are being pulled from somewhere which I'm struggling to find. If these are all 3rd party components then we will struggle to fix these ones. @jeremystretch it will be worth deciding how critical these issues are.

@andrewgormley commented on GitHub (Jul 24, 2024): Similar to the table issues, all of these issues stem from form elements which are being pulled from somewhere which I'm struggling to find. If these are all 3rd party components then we will struggle to fix these ones. @jeremystretch it will be worth deciding how critical these issues are.
adam commented 2025-12-29 21:24:59 +01:00
Author
Owner
Copy Link

@andrewgormley commented on GitHub (Jul 26, 2024):

(Add token) Broken aria references - /user/api-tokens/add/

Screenshot 2024-07-26 at 15 54 48
Screenshot 2024-07-26 at 15 54 55
Screenshot 2024-07-26 at 15 55 01
Screenshot 2024-07-26 at 15 55 06

@andrewgormley commented on GitHub (Jul 26, 2024): (Add token) Broken aria references - /user/api-tokens/add/ ![Screenshot 2024-07-26 at 15 54 48](https://github.com/user-attachments/assets/d5f28608-3ed4-423d-af64-1ac4d386bb09) ![Screenshot 2024-07-26 at 15 54 55](https://github.com/user-attachments/assets/8ead201f-4ef8-4dc4-b200-ac228c08af3e) ![Screenshot 2024-07-26 at 15 55 01](https://github.com/user-attachments/assets/341c5b0d-78b7-4736-9b79-c734b96341c1) ![Screenshot 2024-07-26 at 15 55 06](https://github.com/user-attachments/assets/2b6f3d8f-5447-48c3-929b-e5b983978ff2)
adam commented 2025-12-29 21:24:59 +01:00
Author
Owner
Copy Link

@andrewgormley commented on GitHub (Jul 26, 2024):

(Tables) Missing aria label on quick search box [Multiple]

This issue also exists on the filter input as well, essentially the issue is that placeholder text does not constitute a label, this might be solvable with a hidden label or aria if we're looking to avoid a visible label

Screenshot 2024-07-26 at 15 59 58
Screenshot 2024-07-26 at 16 00 17

@andrewgormley commented on GitHub (Jul 26, 2024): (Tables) Missing aria label on quick search box [Multiple] This issue also exists on the filter input as well, essentially the issue is that placeholder text does not constitute a label, this might be solvable with a hidden label or aria if we're looking to avoid a visible label ![Screenshot 2024-07-26 at 15 59 58](https://github.com/user-attachments/assets/e0d28a90-7490-4fd8-a789-9dbe16efab4b) ![Screenshot 2024-07-26 at 16 00 17](https://github.com/user-attachments/assets/2b19bc07-4945-4e91-9e05-5939f1aaa7b3)
adam commented 2025-12-29 21:24:59 +01:00
Author
Owner
Copy Link

@andrewgormley commented on GitHub (Jul 26, 2024):

(Progress bars) Do not have accessible aria labels. example shown is from the racks object list page. Issue was flagged in Google Lighthouse

Screenshot 2024-07-26 at 16 06 38

@andrewgormley commented on GitHub (Jul 26, 2024): (Progress bars) Do not have accessible aria labels. example shown is from the racks object list page. Issue was flagged in Google Lighthouse ![Screenshot 2024-07-26 at 16 06 38](https://github.com/user-attachments/assets/20a343cd-5416-4113-8215-b8050948e429)
adam commented 2025-12-29 21:24:59 +01:00
Author
Owner
Copy Link

@andrewgormley commented on GitHub (Jul 26, 2024):

(New object) aria broken on slug combo box [Multiple]
(New object) aria broken on input description text [Multiple]
(Misc) Form elements without effective labels [Multiple]

All of these issues stem from form elements, fixing at the component level will likely fix multiple instances across the app. I've used WAVE to pinpoint form elements failing tests.

Screenshots taken from new object page for sites and racks but these issues exist for all form elements across the app.

Screenshot 2024-07-26 at 16 11 53
Screenshot 2024-07-26 at 16 09 25
Screenshot 2024-07-26 at 16 09 31
Screenshot 2024-07-26 at 16 09 34
Screenshot 2024-07-26 at 16 09 55
Screenshot 2024-07-26 at 16 11 44

@andrewgormley commented on GitHub (Jul 26, 2024): (New object) aria broken on slug combo box [Multiple] (New object) aria broken on input description text [Multiple] (Misc) Form elements without effective labels [Multiple] All of these issues stem from form elements, fixing at the component level will likely fix multiple instances across the app. I've used WAVE to pinpoint form elements failing tests. Screenshots taken from new object page for sites and racks but these issues exist for all form elements across the app. ![Screenshot 2024-07-26 at 16 11 53](https://github.com/user-attachments/assets/20f037a3-a543-453e-bbcb-1bc52da0a140) ![Screenshot 2024-07-26 at 16 09 25](https://github.com/user-attachments/assets/a68c4843-f7b8-47ec-ab48-1c24e3a3861a) ![Screenshot 2024-07-26 at 16 09 31](https://github.com/user-attachments/assets/144f3171-f08f-4942-918e-aa3a229d5910) ![Screenshot 2024-07-26 at 16 09 34](https://github.com/user-attachments/assets/8c2a730d-dfcc-4993-8821-1eb2447b1fea) ![Screenshot 2024-07-26 at 16 09 55](https://github.com/user-attachments/assets/decae4d5-fbb0-4481-86ac-95004c4ac0bc) ![Screenshot 2024-07-26 at 16 11 44](https://github.com/user-attachments/assets/aa8382dc-5900-4043-a407-11342b1cc49f)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label complexity: low netbox status: backlog topic: UI/UX type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#9958
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?