starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

VPN proposal API POST requires authentication_algorithm in the request body #9926

New Issue
Closed
opened 2025-12-29 21:24:31 +01:00 by adam · 1 comment
adam commented 2025-12-29 21:24:31 +01:00
Owner
Copy Link

Originally created by @locklearxd on GitHub (Jul 1, 2024).

Originally assigned to: @jeremystretch on GitHub.

Deployment Type

Self-hosted

NetBox Version

v4.0.6

Python Version

3.10

Steps to Reproduce

This can be done via CURL natively in the API via Swagger UI. Confirmed with a raw request.

  1. Send a POST request to the API without the "authentication_algorithm" in the request body or "null" as the value.
  2. Receive a response The request failed with code 400 Bad Request: {'authentication_algorithm': ['This field is required.']}
  3. OR receive a response The request failed with code 400 Bad Request: {'authentication_algorithm': ['null is not a valid choice.']}

Expected Behavior

The web interface supports creation of IKE proposals without an authentication algorithm in the cases where no auth is specified. This creates an object like so visible in the API:
{
"id": 1,
"url": "https://netbox_fqdn_here/api/vpn/ike-proposals/1/",
"display": "default",
"name": "default",
"description": "",
"authentication_method": {
"value": "preshared-keys",
"label": "Pre-shared keys"
},
"encryption_algorithm": {
"value": "aes-128-cbc",
"label": "128-bit AES (CBC)"
},
"authentication_algorithm": null,
"group": {
"value": 2,
"label": "Group 2"
},
"sa_lifetime": null,
"comments": "",
"tags": [],
"custom_fields": {},
"created": "2024-07-01T18:36:23.031219Z",
"last_updated": "2024-07-01T18:52:15.841523Z"
}

So clearly a null value is intended to be supported and should be supported via API as well.
I expected the API to support either the request body to have this as optional or support a null value. It does not appear to.

Observed Behavior

400 Bad Request: {'authentication_algorithm': ['This field is required.']}
400 Bad Request: {'authentication_algorithm': ['null is not a valid choice.']}

Originally created by @locklearxd on GitHub (Jul 1, 2024). Originally assigned to: @jeremystretch on GitHub. ### Deployment Type Self-hosted ### NetBox Version v4.0.6 ### Python Version 3.10 ### Steps to Reproduce This can be done via CURL natively in the API via Swagger UI. Confirmed with a raw request. 1. Send a POST request to the API without the "authentication_algorithm" in the request body or "null" as the value. 2. Receive a response The request failed with code 400 Bad Request: {'authentication_algorithm': ['This field is required.']} 3. OR receive a response The request failed with code 400 Bad Request: {'authentication_algorithm': ['null is not a valid choice.']} ### Expected Behavior The web interface supports creation of IKE proposals without an authentication algorithm in the cases where no auth is specified. This creates an object like so visible in the API: { "id": 1, "url": "https://netbox_fqdn_here/api/vpn/ike-proposals/1/", "display": "default", "name": "default", "description": "", "authentication_method": { "value": "preshared-keys", "label": "Pre-shared keys" }, "encryption_algorithm": { "value": "aes-128-cbc", "label": "128-bit AES (CBC)" }, _**"authentication_algorithm": null**_, "group": { "value": 2, "label": "Group 2" }, "sa_lifetime": null, "comments": "", "tags": [], "custom_fields": {}, "created": "2024-07-01T18:36:23.031219Z", "last_updated": "2024-07-01T18:52:15.841523Z" } So clearly a null value is intended to be supported and should be supported via API as well. I expected the API to support either the request body to have this as optional or support a null value. It does not appear to. ### Observed Behavior 400 Bad Request: {'authentication_algorithm': ['This field is required.']} 400 Bad Request: {'authentication_algorithm': ['null is not a valid choice.']}
adam added the type: bugstatus: acceptedseverity: medium labels 2025-12-29 21:24:31 +01:00
adam closed this issue 2025-12-29 21:24:31 +01:00
adam commented 2025-12-29 21:24:31 +01:00
Author
Owner
Copy Link

@locklearxd commented on GitHub (Jul 8, 2024):

@jeremystretch @arthanson

Sorry I should've included this in the original report, but the same issue occurs for IPsec proposals.

Reproduced with a POST to this API endpoint:

/api/vpn/ipsec-proposals/

I would assume that the fix should be the same, either allowing null values or making it not required.

@locklearxd commented on GitHub (Jul 8, 2024): @jeremystretch @arthanson Sorry I should've included this in the original report, but the same issue occurs for IPsec proposals. Reproduced with a POST to this API endpoint: /api/vpn/ipsec-proposals/ I would assume that the fix should be the same, either allowing null values or making it not required.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label severity: medium status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#9926
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?