starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Upgrade yarn packages #9892

New Issue
Closed
opened 2025-12-29 21:24:03 +01:00 by adam · 3 comments
adam commented 2025-12-29 21:24:03 +01:00
Owner
Copy Link

Originally created by @arthanson on GitHub (Jun 24, 2024).

Proposed Changes

Update yarn js packages to latest (typescript, esbuild, eslint...) using yarn update --latest

Justification

from dev documentation (https://netboxlabs.com/docs/netbox/en/stable/development/web-ui/) it says to run yarn update --latest doing this currently breaks the build / validation. The update to typescript jumps a major version number and shows validation errors in tom-select:

node_modules/tom-select/src/vanilla.ts:100:39 - error TS1536: Octal escape sequences and backreferences are not allowed in a character class. If this was intended as an escape sequence, use the syntax '\x09' instead.

100    _classes = _classes.trim().split(/[\11\12\14\15\40]/);
                                          ~~~

node_modules/tom-select/src/vanilla.ts:100:42 - error TS1536: Octal escape sequences and backreferences are not allowed in a character class. If this was intended as an escape sequence, use the syntax '\x0a' instead.

100    _classes = _classes.trim().split(/[\11\12\14\15\40]/);
                                             ~~~

node_modules/tom-select/src/vanilla.ts:100:45 - error TS1536: Octal escape sequences and backreferences are not allowed in a character class. If this was intended as an escape sequence, use the syntax '\x0c' instead.

100    _classes = _classes.trim().split(/[\11\12\14\15\40]/);

While update to eslint shows errors:

(node:84956) ESLintIgnoreWarning: The ".eslintignore" file is no longer supported. Switch to using the "ignores" property in "eslint.config.js": https://eslint.org/docs/latest/use/configure/migration-guide#ignoring-files
(Use `node --trace-warnings ...` to show where the warning was created)

Oops! Something went wrong! :(

ESLint: 9.5.0

/Users/arthurhanson/dev/work/netbox/netbox/project-static/.eslintrc:2
  "root": true,
        ^
Originally created by @arthanson on GitHub (Jun 24, 2024). ### Proposed Changes Update yarn js packages to latest (typescript, esbuild, eslint...) using `yarn update --latest` ### Justification from dev documentation (https://netboxlabs.com/docs/netbox/en/stable/development/web-ui/) it says to run `yarn update --latest` doing this currently breaks the build / validation. The update to typescript jumps a major version number and shows validation errors in tom-select: ``` node_modules/tom-select/src/vanilla.ts:100:39 - error TS1536: Octal escape sequences and backreferences are not allowed in a character class. If this was intended as an escape sequence, use the syntax '\x09' instead. 100 _classes = _classes.trim().split(/[\11\12\14\15\40]/); ~~~ node_modules/tom-select/src/vanilla.ts:100:42 - error TS1536: Octal escape sequences and backreferences are not allowed in a character class. If this was intended as an escape sequence, use the syntax '\x0a' instead. 100 _classes = _classes.trim().split(/[\11\12\14\15\40]/); ~~~ node_modules/tom-select/src/vanilla.ts:100:45 - error TS1536: Octal escape sequences and backreferences are not allowed in a character class. If this was intended as an escape sequence, use the syntax '\x0c' instead. 100 _classes = _classes.trim().split(/[\11\12\14\15\40]/); ``` While update to eslint shows errors: ``` (node:84956) ESLintIgnoreWarning: The ".eslintignore" file is no longer supported. Switch to using the "ignores" property in "eslint.config.js": https://eslint.org/docs/latest/use/configure/migration-guide#ignoring-files (Use `node --trace-warnings ...` to show where the warning was created) Oops! Something went wrong! :( ESLint: 9.5.0 /Users/arthurhanson/dev/work/netbox/netbox/project-static/.eslintrc:2 "root": true, ^ ```
adam added the type: housekeeping label 2025-12-29 21:24:03 +01:00
adam closed this issue 2025-12-29 21:24:04 +01:00
adam commented 2025-12-29 21:24:04 +01:00
Author
Owner
Copy Link

@marsteel commented on GitHub (Jul 3, 2024):

Yes,
There is also a security finding https://security.snyk.io/package/npm/braces/3.0.2
Bump braces from 3.0.2 to 3.0.3 in /netbox/project-static #1

@marsteel commented on GitHub (Jul 3, 2024): Yes, There is also a security finding https://security.snyk.io/package/npm/braces/3.0.2 Bump braces from 3.0.2 to 3.0.3 in /netbox/project-static #1
adam commented 2025-12-29 21:24:05 +01:00
Author
Owner
Copy Link

@alejandrohg1 commented on GitHub (Aug 13, 2024):

Hi did you find a way to fix this, if so how did you do it , ty so much

@alejandrohg1 commented on GitHub (Aug 13, 2024): Hi did you find a way to fix this, if so how did you do it , ty so much
adam commented 2025-12-29 21:24:05 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Aug 14, 2024):

This will be addressed in #16245

@jeremystretch commented on GitHub (Aug 14, 2024): This will be addressed in #16245
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label type: housekeeping
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#9892
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?