starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Define a get_absolute_url() method on NetBoxModel #9838

New Issue
Closed
opened 2025-12-29 21:23:25 +01:00 by adam · 2 comments
adam commented 2025-12-29 21:23:25 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (Jun 13, 2024).

Originally assigned to: @arthanson on GitHub.

Proposed Changes

Add a get_absolute_url() method on NetBoxModel to dynamically return the appropriate URL based on the model's app_label and model_name Meta attributes:

    def get_absolute_url(self):
        return reverse(f'{self._meta.app_label}:{model_name}', args=[self.pk])

Justification

The vast majority of models in NetBox declare this method explicitly. Moving it to NetBoxModel allows us to remove boilerplate code while still permitting customization on individual models.

Originally created by @jeremystretch on GitHub (Jun 13, 2024). Originally assigned to: @arthanson on GitHub. ### Proposed Changes Add a [`get_absolute_url()`](https://docs.djangoproject.com/en/5.0/ref/models/instances/#get-absolute-url) method on NetBoxModel to dynamically return the appropriate URL based on the model's `app_label` and `model_name` Meta attributes: ```python def get_absolute_url(self): return reverse(f'{self._meta.app_label}:{model_name}', args=[self.pk]) ``` ### Justification The vast majority of models in NetBox declare this method explicitly. Moving it to NetBoxModel allows us to remove boilerplate code while still permitting customization on individual models.
adam added the status: acceptedtype: housekeeping labels 2025-12-29 21:23:25 +01:00
adam closed this issue 2025-12-29 21:23:25 +01:00
adam commented 2025-12-29 21:23:26 +01:00
Author
Owner
Copy Link

@sleepinggenius2 commented on GitHub (Jun 14, 2024):

Would the proposed solution work for plugin models that inherit from NetBoxModel too? It would be nice to do away with the boilerplate there as well.

@sleepinggenius2 commented on GitHub (Jun 14, 2024): Would the proposed solution work for plugin models that inherit from NetBoxModel too? It would be nice to do away with the boilerplate there as well.
adam commented 2025-12-29 21:23:26 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Nov 25, 2024):

A get_absolute_url() method has been added to the NetBoxFeatureSet mixin, which is used by NetBoxModel, OrganizationalModel, and NestedGroupModel.

@jeremystretch commented on GitHub (Nov 25, 2024): A `get_absolute_url()` method has been added to the NetBoxFeatureSet mixin, which is used by NetBoxModel, OrganizationalModel, and NestedGroupModel.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: housekeeping
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#9838
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?