starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Employ pre-commit for commit validation #9719

New Issue
Closed
opened 2025-12-29 21:21:35 +01:00 by adam · 2 comments
adam commented 2025-12-29 21:21:35 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (May 22, 2024).

Originally assigned to: @jeremystretch on GitHub.

Proposed Changes

Replace our current pre-commit hook script with pre-commit.

Justification

Obviates the need for a custom script while at the same time exposing more powerful validation features.

Originally created by @jeremystretch on GitHub (May 22, 2024). Originally assigned to: @jeremystretch on GitHub. ### Proposed Changes Replace our current [pre-commit hook script](https://github.com/netbox-community/netbox/blob/develop/scripts/git-hooks/pre-commit) with [`pre-commit`](https://pre-commit.com/). ### Justification Obviates the need for a custom script while at the same time exposing more powerful validation features.
adam added the status: acceptedtype: housekeeping labels 2025-12-29 21:21:35 +01:00
adam closed this issue 2025-12-29 21:21:35 +01:00
adam commented 2025-12-29 21:21:36 +01:00
Author
Owner
Copy Link

@ITJamie commented on GitHub (May 23, 2024):

Im a heavy pre-commit user, i am happy to make a pr towards this

@ITJamie commented on GitHub (May 23, 2024): Im a heavy pre-commit user, i am happy to make a pr towards this
adam commented 2025-12-29 21:21:36 +01:00
Author
Owner
Copy Link

@github-actions[bot] commented on GitHub (Aug 21, 2024):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Do not attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our contributing guide.

@github-actions[bot] commented on GitHub (Aug 21, 2024): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. **Do not** attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our [contributing guide](https://github.com/netbox-community/netbox/blob/develop/CONTRIBUTING.md).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: housekeeping
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#9719
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?