starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Add current NetBox version in the PluginConfig.validate() error output #9653

New Issue
Closed
opened 2025-12-29 21:20:24 +01:00 by adam · 1 comment
adam commented 2025-12-29 21:20:24 +01:00
Owner
Copy Link

Originally created by @markkuleinio on GitHub (May 11, 2024).

Originally assigned to: @markkuleinio on GitHub.

NetBox version

v4.0.1

Feature type

New functionality

Proposed functionality

When PluginConfig.validate() determines that the current NetBox version does not meet the plugin requirements, also print out the current NetBox version in the exception message.

Use case

Currently the error message only prints the version that the plugin mandates, but due to possible installation directory confusion it would be good to also print the current NetBox version. Example case: https://github.com/netbox-community/netbox/issues/16088

Database changes

None

External dependencies

None

Originally created by @markkuleinio on GitHub (May 11, 2024). Originally assigned to: @markkuleinio on GitHub. ### NetBox version v4.0.1 ### Feature type New functionality ### Proposed functionality When [`PluginConfig.validate()`](https://github.com/netbox-community/netbox/blob/4a64a3f6e0d0edf27996422eb2dbe0e197a6bea5/netbox/netbox/plugins/__init__.py#L133) determines that the current NetBox version does not meet the plugin requirements, also print out the current NetBox version in the exception message. ### Use case Currently the error message only prints the version that the plugin mandates, but due to possible installation directory confusion it would be good to also print the current NetBox version. Example case: https://github.com/netbox-community/netbox/issues/16088 ### Database changes None ### External dependencies None
adam added the status: acceptedtype: feature labels 2025-12-29 21:20:24 +01:00
adam closed this issue 2025-12-29 21:20:24 +01:00
adam commented 2025-12-29 21:20:25 +01:00
Author
Owner
Copy Link

@markkuleinio commented on GitHub (May 11, 2024):

If this is accepted, I can send the PR.

@markkuleinio commented on GitHub (May 11, 2024): If this is accepted, I can send the PR.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#9653
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?