starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Omit the django-prometheus middleware if METRICS_ENABLED is false #9610

New Issue
Closed
opened 2025-12-29 21:19:43 +01:00 by adam · 0 comments
adam commented 2025-12-29 21:19:43 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (May 7, 2024).

Originally assigned to: @jeremystretch on GitHub.

Proposed Changes

NetBox supports the export of Prometheus metrics via django-prometheus if configured to do so. Metrics export is disabled by default, however the middleware is still active. This issue proposes enabling the middleware only when METRICS_ENABLED is true.

Justification

We may be able to optimize performance and shrink our bug surface a bit by disabling this middleware when metrics are not in use.

Originally created by @jeremystretch on GitHub (May 7, 2024). Originally assigned to: @jeremystretch on GitHub. ### Proposed Changes NetBox supports the export of Prometheus metrics via [django-prometheus](https://github.com/korfuri/django-prometheus) if [configured to do so](https://docs.netbox.dev/en/stable/configuration/miscellaneous/#metrics_enabled). Metrics export is disabled by default, however the middleware is still active. This issue proposes enabling the middleware only when `METRICS_ENABLED` is true. ### Justification We may be able to optimize performance and shrink our bug surface a bit by disabling this middleware when metrics are not in use.
adam added the status: acceptedtype: housekeeping labels 2025-12-29 21:19:43 +01:00
adam closed this issue 2025-12-29 21:19:43 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: housekeeping
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#9610
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?