New matching case for related devices UI #952

New Issue

adam · 2025-12-29T16:27:13+01:00

adam commented

2025-12-29 16:27:13 +01:00

Originally created by @lampwins on GitHub (May 15, 2017).

Issue type: feature request

There was some discussion on the networktocode slack the other day about how related devices are correlated. I know @jeremystretch mentioned wanting revisit this in a larger fashion but I was wondering if you would be open to adding one more case for matching in the mean time.

This stems from the way I am currently representing switch stacks in netbox. Each member of the stack is named like so: Access-Stack-1F--RE-N1. In this scheme, Access-Stack-1F is the name of the stack and this node's role is RE and it is node 1 in the stack. This is denoted after the delimiter --.

I really like the related devices feature but it obviously cannot match all members of a stack in this case when we factor in multiple roles (RE, LC, etc). Would it be possible to add a case to match anything up to a delimiter of --?

Originally created by @lampwins on GitHub (May 15, 2017).  ### Issue type: feature request There was some discussion on the networktocode slack the other day about how related devices are correlated. I know @jeremystretch mentioned wanting revisit this in a larger fashion but I was wondering if you would be open to adding one more case for matching in the mean time. This stems from the way I am currently representing switch stacks in netbox. Each member of the stack is named like so: `Access-Stack-1F--RE-N1`. In this scheme, `Access-Stack-1F` is the name of the stack and this node's role is `RE` and it is node 1 in the stack. This is denoted after the delimiter `--`. I really like the related devices feature but it obviously cannot match all members of a stack in this case when we factor in multiple roles (RE, LC, etc). Would it be possible to add a case to match anything up to a delimiter of `--`?

adam added the type: feature label 2025-12-29 16:27:13 +01:00

adam closed this issue

2025-12-29 16:27:13 +01:00

adam commented

2025-12-29 16:27:14 +01:00

@jeremystretch commented on GitHub (May 15, 2017):

The current approach of looking for devices with similar names was a "good enough" hack for when it was implemented. It should really be replaced with something more robust, but I don't have anything in mind.

@jeremystretch commented on GitHub (May 15, 2017): The current approach of looking for devices with similar names was a "good enough" hack for when it was implemented. It should really be replaced with something more robust, but I don't have anything in mind.

adam commented

2025-12-29 16:27:14 +01:00

@lampwins commented on GitHub (May 16, 2017):

Coincidentally I ran across the python built in difflib library in some other work today. It immediately struck me a possible solution to this. Among other things, it can be used to calculate a percentile difference in two string. So for instance, you could say something like: two device names that are >=90% similar are related. http://stackoverflow.com/questions/17388213/find-the-similarity-percent-between-two-strings

@lampwins commented on GitHub (May 16, 2017): Coincidentally I ran across the python built in `difflib` library in some other work today. It immediately struck me a possible solution to this. Among other things, it can be used to calculate a percentile difference in two string. So for instance, you could say something like: two device names that are >=90% similar are related. http://stackoverflow.com/questions/17388213/find-the-similarity-percent-between-two-strings

adam commented

2025-12-29 16:27:14 +01:00

@jeremystretch commented on GitHub (May 16, 2017):

It's one way to go. We'd have to pull in the names from all devices from the database and then do the matching in Python, but that might not be too bad if we limit it to devices assigned to the same site.

@jeremystretch commented on GitHub (May 16, 2017): It's one way to go. We'd have to pull in the names from all devices from the database and then do the matching in Python, but that might not be too bad if we limit it to devices assigned to the same site.

adam commented

2025-12-29 16:27:14 +01:00

@jeremystretch commented on GitHub (Jun 9, 2017):

difflib has some really neat logic, but after some experimentation it can sometimes return very unexpected results. Probably best to keep things simple and just return a truncated list of devices in the same site with the same role.

@jeremystretch commented on GitHub (Jun 9, 2017): `difflib` has some really neat logic, but after some experimentation it can sometimes return very unexpected results. Probably best to keep things simple and just return a truncated list of devices in the same site with the same role.

adam referenced this issue

2025-12-29 22:19:50 +01:00

[PR #954] [MERGED] Force Unix line endings on shell scripts #12140

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#952