starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Add Image Attachments to Virtual Machines #9472

New Issue
Closed
opened 2025-12-29 20:50:21 +01:00 by adam · 4 comments
adam commented 2025-12-29 20:50:21 +01:00
Owner
Copy Link

Originally created by @Hedius on GitHub (Apr 12, 2024).

Originally assigned to: @Hedius on GitHub.

NetBox version

4.0

Feature type

New functionality

Proposed functionality

Extend virtual machines with the ability to add image attachments.

  1. Inherit the ImageAttachmentsMixin in the VirtualMachine model.
  2. Add the required template to the object view for VMs

https://github.com/Hedius/netbox/tree/15712-add_imageattachments_to_virtualmachines

Use case

I acknowledge that this feature (according to the FAQ) is or was initially meant for uploading photos of hardware and racks.

Our NetBox partly evolved into us uploading diagrams etc. into devices to extend the comment section with them.
(We document there what a host / server is doing etc.)
It would be a nice to have if we can do the same in virtual machines.
Main advantage is that you have those images directly linked to the host.

I do not know how other organizations use this feature, but having the same abilities for bare metal servers and virtual machines seems right to me.

Would this change be acceptable to you?

Adding the modal to VMs would not extend the complexity of NetBox.

Database changes

None

External dependencies

None

Originally created by @Hedius on GitHub (Apr 12, 2024). Originally assigned to: @Hedius on GitHub. ### NetBox version 4.0 ### Feature type New functionality ### Proposed functionality Extend virtual machines with the ability to add image attachments. 1. Inherit the ImageAttachmentsMixin in the VirtualMachine model. 2. Add the required template to the object view for VMs https://github.com/Hedius/netbox/tree/15712-add_imageattachments_to_virtualmachines ### Use case I acknowledge that this feature (according to the FAQ) is or was initially meant for uploading photos of hardware and racks. Our NetBox partly evolved into us uploading diagrams etc. into devices to extend the comment section with them. (We document there what a host / server is doing etc.) It would be a nice to have if we can do the same in virtual machines. Main advantage is that you have those images directly linked to the host. I do not know how other organizations use this feature, but having the same abilities for bare metal servers and virtual machines seems right to me. Would this change be acceptable to you? Adding the modal to VMs would not extend the complexity of NetBox. ### Database changes None ### External dependencies None
adam added the status: acceptedtype: feature labels 2025-12-29 20:50:21 +01:00
adam closed this issue 2025-12-29 20:50:21 +01:00
adam commented 2025-12-29 20:50:22 +01:00
Author
Owner
Copy Link

@Hedius commented on GitHub (Apr 12, 2024):

I would like to open a pull request for this if this request gets accepted: https://github.com/Hedius/netbox/tree/15712-add_imageattachments_to_virtualmachines provides the required changes.

The dialog told me not to do it, before it gets accepted :)

@Hedius commented on GitHub (Apr 12, 2024): I would like to open a pull request for this if this request gets accepted: https://github.com/Hedius/netbox/tree/15712-add_imageattachments_to_virtualmachines provides the required changes. The dialog told me not to do it, before it gets accepted :)
adam commented 2025-12-29 20:50:22 +01:00
Author
Owner
Copy Link

@jeffgdotorg commented on GitHub (Apr 18, 2024):

Thanks for your interest in helping improve NetBox, and especially for the well-reasoned issue body. It makes sense to me even though the front / rear image support for Devices exists at the Device Type level, for which no analog currently exists in VMs.

I'm moving this issue into accepted and assigning to you for implementation. Two caveats:

  • I notice that the FR specifies NetBox 4.0, while your branch appears to be based on develop. You'll need to rebase against feature if that's the release you mean to target.
  • The accepted status label is provisional; I'm just triaging at this point.
@jeffgdotorg commented on GitHub (Apr 18, 2024): Thanks for your interest in helping improve NetBox, and especially for the well-reasoned issue body. It makes sense to me even though the front / rear image support for Devices exists at the Device Type level, for which no analog currently exists in VMs. I'm moving this issue into `accepted` and assigning to you for implementation. Two caveats: - I notice that the FR specifies NetBox 4.0, while your branch appears to be based on `develop`. You'll need to rebase against `feature` if that's the release you mean to target. - The `accepted` status label is provisional; I'm just triaging at this point.
adam commented 2025-12-29 20:50:23 +01:00
Author
Owner
Copy Link

@Hedius commented on GitHub (Apr 19, 2024):

Thank you for the provisional accepted status.

My feature branch for the issue is based on the feature branch, but i only have the develop branch in my fork and it compares to that one.

Will rebase it and then open a PR.

@Hedius commented on GitHub (Apr 19, 2024): Thank you for the provisional accepted status. My feature branch for the issue is based on the feature branch, but i only have the develop branch in my fork and it compares to that one. Will rebase it and then open a PR.
adam commented 2025-12-29 20:50:23 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Apr 19, 2024):

Tagging this for v4.0.

@jeremystretch commented on GitHub (Apr 19, 2024): Tagging this for v4.0.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#9472
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?