starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Switch between dark/light mode doesn't take effect until user logs out and back in #9439

New Issue
Closed
opened 2025-12-29 20:49:58 +01:00 by adam · 5 comments
adam commented 2025-12-29 20:49:58 +01:00
Owner
Copy Link

Originally created by @jhammond-git on GitHub (Apr 4, 2024).

Originally assigned to: @jeremystretch on GitHub.

Deployment Type

Self-hosted

NetBox Version

v4.0-beta1

Python Version

3.10

Steps to Reproduce

  1. Log in as a user.
  2. Click on the User menu in the top right
  3. Click Preferences
  4. Change color mode, and click Save at the bottom

Expected Behavior

Color mode changes as soon as Save is clicked and the page refreshes to the new mode.

Observed Behavior

Color mode doesn't change until user logs out of Netbox and back in.

Originally created by @jhammond-git on GitHub (Apr 4, 2024). Originally assigned to: @jeremystretch on GitHub. ### Deployment Type Self-hosted ### NetBox Version v4.0-beta1 ### Python Version 3.10 ### Steps to Reproduce 1. Log in as a user. 2. Click on the User menu in the top right 3. Click Preferences 4. Change color mode, and click Save at the bottom ### Expected Behavior Color mode changes as soon as Save is clicked and the page refreshes to the new mode. ### Observed Behavior Color mode doesn't change until user logs out of Netbox and back in.
adam added the type: bugstatus: acceptedbetaseverity: low labels 2025-12-29 20:49:58 +01:00
adam closed this issue 2025-12-29 20:49:59 +01:00
adam commented 2025-12-29 20:49:59 +01:00
Author
Owner
Copy Link

@jhammond-git commented on GitHub (Apr 5, 2024):

I went back to my production (3.7.4) and discovered it does the same in the Preferences menu, but also found the menu item for light/dark mode switch which takes effect immediately. That led me to the button which I noticed in beta that has the same function, but I didn't realize it was a button before.

Having said all that, I don't see why the preference can't change mode on Save, but I can also see why that wouldn't be a reasonable use of development time.

@jhammond-git commented on GitHub (Apr 5, 2024): I went back to my production (3.7.4) and discovered it does the same in the Preferences menu, but also found the menu item for light/dark mode switch which takes effect immediately. That led me to the button which I noticed in beta that has the same function, but I didn't realize it was a button before. Having said all that, I don't see why the preference can't change mode on Save, but I can also see why that wouldn't be a reasonable use of development time.
adam commented 2025-12-29 20:49:59 +01:00
Author
Owner
Copy Link

@jeffgdotorg commented on GitHub (Apr 8, 2024):

The first time I tried to reproduce this issue (going from dark to light), it behaved as expected. Each subsequent time I was able to reproduce it consistently regardless of which direction the color mode was going.

@jeffgdotorg commented on GitHub (Apr 8, 2024): The first time I tried to reproduce this issue (going from dark to light), it behaved as expected. Each subsequent time I was able to reproduce it consistently regardless of which direction the color mode was going.
adam commented 2025-12-29 20:49:59 +01:00
Author
Owner
Copy Link

@Julio-Oliveira-Encora commented on GitHub (Apr 9, 2024):

When the color mode is changed in User Preferences, you must log out and log in again for the changes to be applied. On the other hand, if you select "Dark" or "Light" on Preferences, the change is applied at the same time.

If you want to apply the changes as soon as the color mode changes, please assign this ticket to me.

@Julio-Oliveira-Encora commented on GitHub (Apr 9, 2024): When the color mode is changed in User Preferences, you must log out and log in again for the changes to be applied. On the other hand, if you select "Dark" or "Light" on Preferences, the change is applied at the same time. If you want to apply the changes as soon as the color mode changes, please assign this ticket to me.
adam commented 2025-12-29 20:50:00 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Apr 22, 2024):

The root issue is that the user preference is stored on the backend, whereas the live toggle (the button at top right) saves its setting in local storage. So we can end up with a conflicting state where the user's preference indicates dark mode but local storage indicates light mode, or vice versa.

Honestly it feels like overkill to track light/dark mode as a preference anyway. I can easily see this being device- or time-dependent, and the live toggle makes much more sense IMO. Maybe we should just ditch the stored preference altogether.

@jeremystretch commented on GitHub (Apr 22, 2024): The root issue is that the user preference is stored on the backend, whereas the live toggle (the button at top right) saves its setting in local storage. So we can end up with a conflicting state where the user's preference indicates dark mode but local storage indicates light mode, or vice versa. Honestly it feels like overkill to track light/dark mode as a preference anyway. I can easily see this being device- or time-dependent, and the live toggle makes much more sense IMO. Maybe we should just ditch the stored preference altogether.
adam commented 2025-12-29 20:50:00 +01:00
Author
Owner
Copy Link

@DanSheps commented on GitHub (Apr 23, 2024):

Honestly it feels like overkill to track light/dark mode as a preference anyway. I can easily see this being device- or time-dependent, and the live toggle makes much more sense IMO. Maybe we should just ditch the stored preference altogether.

The one arguement I could see is that if you move to new devices frequently, however I think that is a corner case and not the norm so we might not even care about it.

@DanSheps commented on GitHub (Apr 23, 2024): > Honestly it feels like overkill to track light/dark mode as a preference anyway. I can easily see this being device- or time-dependent, and the live toggle makes much more sense IMO. Maybe we should just ditch the stored preference altogether. The one arguement I could see is that if you move to new devices frequently, however I think that is a corner case and not the norm so we might not even care about it.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label beta severity: low status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#9439
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?