starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Sidebar not affected by color theme change #9430

New Issue
Closed
opened 2025-12-29 20:49:51 +01:00 by adam · 5 comments
adam commented 2025-12-29 20:49:51 +01:00
Owner
Copy Link

Originally created by @julianstolp on GitHub (Apr 4, 2024).

Deployment Type

NetBox Cloud

NetBox Version

v4.0-beta1

Python Version

3.10

Steps to Reproduce

  1. Click the bulb in the top right corner to toggle the color mode to light mode

Expected Behavior

Sidebar swiches to light mode

Observed Behavior

Sidebar stays dark

The theme is hardcoded to data-bs-theme="dark"

<aside class="navbar navbar-vertical navbar-expand-lg" data-bs-theme="dark">

Originally created by @julianstolp on GitHub (Apr 4, 2024). ### Deployment Type NetBox Cloud ### NetBox Version v4.0-beta1 ### Python Version 3.10 ### Steps to Reproduce 1. Click the bulb in the top right corner to toggle the color mode to light mode ### Expected Behavior Sidebar swiches to light mode ### Observed Behavior Sidebar stays dark The theme is hardcoded to `data-bs-theme="dark"` `<aside class="navbar navbar-vertical navbar-expand-lg" data-bs-theme="dark">`
adam closed this issue 2025-12-29 20:49:52 +01:00
adam commented 2025-12-29 20:49:52 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Apr 4, 2024):

Yes, this is intentional.

@jeremystretch commented on GitHub (Apr 4, 2024): Yes, this is intentional.
adam commented 2025-12-29 20:49:53 +01:00
Author
Owner
Copy Link

@candlerb commented on GitHub (Apr 23, 2024):

I'm not sure why this is intentional - IMO the combination looks terrible.

image

I know that dark mode is the trendy view these days, but I'm used to light mode and my eyes prefer it. Mixed dark/light just looks like a rendering bug.

Secondary issue: the navigation menu no longer collapses. It's not really an issue on a desktop monitor, but on a laptop it significantly reduces the amount of space available for data display.

@candlerb commented on GitHub (Apr 23, 2024): I'm not sure why this is intentional - IMO the combination looks terrible. ![image](https://github.com/netbox-community/netbox/assets/44789/87ef50c3-6ecb-409c-b08c-a7b9cd7eaf34) I know that dark mode is the trendy view these days, but I'm used to light mode and my eyes prefer it. Mixed dark/light just looks like a rendering bug. Secondary issue: the navigation menu no longer collapses. It's not really an issue on a desktop monitor, but on a laptop it significantly reduces the amount of space available for data display.
adam commented 2025-12-29 20:49:53 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Apr 23, 2024):

IMO the combination looks terrible

We'll have to disagree; I quite like it. You'll note it's also the style preferred in Tabler's live demo. But that's the great thing about open source: You're always free to modify the code to your liking.

Secondary issue: the navigation menu no longer collapses. It's not really an issue on a desktop monitor, but on a laptop it significantly reduces the amount of space available for data display.

I don't see any need for it, but #15614 is open for an owner. We'll see if there's any overlap between people who see value in the functionality and people willing to contribute their time and effort implementing it.

@jeremystretch commented on GitHub (Apr 23, 2024): > IMO the combination looks terrible We'll have to disagree; I quite like it. You'll note it's also the style preferred in [Tabler's live demo](https://tabler.io/preview). But that's the great thing about open source: You're always free to modify the code to your liking. > Secondary issue: the navigation menu no longer collapses. It's not really an issue on a desktop monitor, but on a laptop it significantly reduces the amount of space available for data display. I don't see any need for it, but #15614 is open for an owner. We'll see if there's any overlap between people who see value in the functionality and people willing to contribute their time and effort implementing it.
adam commented 2025-12-29 20:49:53 +01:00
Author
Owner
Copy Link

@candlerb commented on GitHub (Apr 23, 2024):

You'll note it's also the style preferred in Tabler's live demo

Can you give a specific location? Do you mean "Layout > Vertical" and/or "Layout > Condensed"? But there are also "Layout > Vertical Transparent" and "Layout > Right Vertical" which use light mode for navigation, at least when the browser is in light mode. I don't see any indication that one is "preferred" over the other.

Cross-ref: FR https://github.com/tabler/tabler/issues/1803 shows examples of both light mode and collapsible navigation.

@candlerb commented on GitHub (Apr 23, 2024): > You'll note it's also the style preferred in [Tabler's live demo](https://tabler.io/preview) Can you give a specific location? Do you mean "Layout > Vertical" and/or "Layout > Condensed"? But there are also "Layout > Vertical Transparent" and "Layout > Right Vertical" which use light mode for navigation, at least when the browser is in light mode. I don't see any indication that one is "preferred" over the other. Cross-ref: FR https://github.com/tabler/tabler/issues/1803 shows examples of both light mode and collapsible navigation.
adam commented 2025-12-29 20:49:53 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Apr 23, 2024):

Can you give a specific location?

Sorry; their demo site uses frames. The combined layout (which is what we use in v4.0) is what I intended to link.

@jeremystretch commented on GitHub (Apr 23, 2024): > Can you give a specific location? Sorry; their demo site uses frames. The [combined layout](https://preview.tabler.io/layout-combo.html) (which is what we use in v4.0) is what I intended to link.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#9430
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?