starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Document the value behind "Default" for the Custom Link "Button Class" #9418

New Issue
Closed
opened 2025-12-29 20:49:33 +01:00 by adam · 3 comments
adam commented 2025-12-29 20:49:33 +01:00
Owner
Copy Link

Originally created by @maddin8 on GitHub (Apr 2, 2024).

Originally assigned to: @arthanson on GitHub.

Change Type

Addition

Area

Customization

Proposed Changes

I would like to propose that aside from the possible non-default values for "Button Class"/"button_class" of Custom Links, documentation is updated to include the information that the value displayed as "Default" in the Netbox UI is actually called "outline-dark". "Default" is as well included in CSV exports of Custom Links from already populated instances, which makes it harder for non-experienced users to determine what value to provide when mass-importing Custom Links with a button_class of "Default"(/"outline-dark").

I originally raised this in #15596 which hopefully provides enough reason why I think this should be included in the documentation.

Originally created by @maddin8 on GitHub (Apr 2, 2024). Originally assigned to: @arthanson on GitHub. ### Change Type Addition ### Area Customization ### Proposed Changes I would like to propose that aside from the possible non-default values for "Button Class"/"button_class" of Custom Links, documentation is updated to include the information that the value displayed as "Default" in the Netbox UI is actually called "outline-dark". "Default" is as well included in CSV exports of Custom Links from already populated instances, which makes it harder for non-experienced users to determine what value to provide when mass-importing Custom Links with a button_class of "Default"(/"outline-dark"). I originally raised this in #15596 which hopefully provides enough reason why I think this should be included in the documentation.
adam added the type: bugstatus: acceptedseverity: low labels 2025-12-29 20:49:34 +01:00
adam closed this issue 2025-12-29 20:49:34 +01:00
adam commented 2025-12-29 20:49:34 +01:00
Author
Owner
Copy Link

@maddin8 commented on GitHub (Apr 2, 2024):

Updated formatting of the table in the second commit.

@maddin8 commented on GitHub (Apr 2, 2024): Updated formatting of the table in the second commit.
adam commented 2025-12-29 20:49:34 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Apr 3, 2024):

It would not be appropriate to duplicate all these entries in the written documentation. Instead, the field definition under the CSV import form should include a help button which displays the available choices, as exists for similar fields. (button_class should be defined on the form as a CSVChoiceField.)

@maddin8 do you want to try this?

@jeremystretch commented on GitHub (Apr 3, 2024): It would not be appropriate to duplicate all these entries in the written documentation. Instead, the field definition under the CSV import form should include a help button which displays the available choices, as exists for similar fields. (`button_class` should be defined on the form as a CSVChoiceField.) @maddin8 do you want to try this?
adam commented 2025-12-29 20:49:34 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Apr 3, 2024):

Reclassified this as a bug, as the import form field is not of the correct type.

@jeremystretch commented on GitHub (Apr 3, 2024): Reclassified this as a bug, as the import form field is not of the correct type.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label severity: low status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#9418
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?