starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Clean up boilerplate form field initialization code #941

New Issue
Closed
opened 2025-12-29 16:27:08 +01:00 by adam · 0 comments
adam commented 2025-12-29 16:27:08 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (May 11, 2017).

Many of the forms within NetBox utilize chained select fields which are populated with options dynamically as the user make selections. Additional logic is necessary to populate these fields when the form is first rendered and bound or initial data is provided. Currently, this is accomplished using boilerplate which follows a pattern similar to the code below:

        # Initialize device choices if rack or site is set
        if self.initial.get('rack'):
            self.fields['device'].queryset = Device.objects.filter(rack=self.initial['rack'])
        elif self.initial.get('site'):
            self.fields['device'].queryset = Device.objects.filter(site=self.initial['site'], rack__isnull=True)
        else:
            self.fields['device'].choices = []

This can be simplified by introducing a new type of form field which will automatically perform the necessary queryset filtering on form initialization.

Originally created by @jeremystretch on GitHub (May 11, 2017). Many of the forms within NetBox utilize chained select fields which are populated with options dynamically as the user make selections. Additional logic is necessary to populate these fields when the form is first rendered and bound or initial data is provided. Currently, this is accomplished using boilerplate which follows a pattern similar to the code below: ``` # Initialize device choices if rack or site is set if self.initial.get('rack'): self.fields['device'].queryset = Device.objects.filter(rack=self.initial['rack']) elif self.initial.get('site'): self.fields['device'].queryset = Device.objects.filter(site=self.initial['site'], rack__isnull=True) else: self.fields['device'].choices = [] ``` This can be simplified by introducing a new type of form field which will automatically perform the necessary queryset filtering on form initialization.
adam added the type: feature label 2025-12-29 16:27:08 +01:00
adam closed this issue 2025-12-29 16:27:08 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#941
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?