Sub filters on GraphQL broken for some queries #9399

New Issue

adam · 2025-12-29T20:49:19+01:00

adam commented

2025-12-29 20:49:19 +01:00

Originally created by @arthanson on GitHub (Mar 27, 2024).

Originally assigned to: @arthanson on GitHub.

Deployment Type

Self-hosted

NetBox Version

v4.0.0

Python Version

3.8

Steps to Reproduce

Found while updating the GraphQL docs for Strawberry. When the sub-field is defined as a function the filtering logic is not applied to it and therefore filtering logic won't work. For example the following query with sub-filter doesn't work:

{
  device_list {
    id
    name
    interfaces(filters: {enabled: {exact: true}}) {
      name
    }
  }
}

This is because it is defined as a function:

    @strawberry_django.field
    def interfaces(self) -> List[Annotated["InterfaceType", strawberry.lazy('dcim.graphql.types')]]:
        return self.interfaces.all()

If it is defined as a line type the filtering does work, but this will not work for fields that have to be defined as functions because the accessor is different:

    interfaces: List[Annotated["InterfaceType", strawberry.lazy('dcim.graphql.types')]]

Adding the filters directly to the decorator does not work either:

    @strawberry_django.field(filters=InterfaceFilter)

Expected Behavior

Filtering should work on all sub-objects

Observed Behavior

Filtering does not work on sub sub-objects.

Originally created by @arthanson on GitHub (Mar 27, 2024). Originally assigned to: @arthanson on GitHub. ### Deployment Type Self-hosted ### NetBox Version v4.0.0 ### Python Version 3.8 ### Steps to Reproduce Found while updating the GraphQL docs for Strawberry. When the sub-field is defined as a function the filtering logic is not applied to it and therefore filtering logic won't work. For example the following query with sub-filter doesn't work: ``` { device_list { id name interfaces(filters: {enabled: {exact: true}}) { name } } } ``` This is because it is defined as a function: ``` @strawberry_django.field def interfaces(self) -> List[Annotated["InterfaceType", strawberry.lazy('dcim.graphql.types')]]: return self.interfaces.all() ``` If it is defined as a line type the filtering does work, but this will not work for fields that have to be defined as functions because the accessor is different: ``` interfaces: List[Annotated["InterfaceType", strawberry.lazy('dcim.graphql.types')]] ``` Adding the filters directly to the decorator does not work either: ``` @strawberry_django.field(filters=InterfaceFilter) ``` ### Expected Behavior Filtering should work on all sub-objects ### Observed Behavior Filtering does not work on sub sub-objects.

adam added the type: bug status: accepted severity: medium labels 2025-12-29 20:49:19 +01:00

adam closed this issue

2025-12-29 20:49:19 +01:00

Sign in to join this conversation.

Branches Tags

main

21102-fix-graphiql-explorer

update-changelog-comments-docs

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#9399