starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Remove obsolete device_role field from REST API serializer for device model #9302

New Issue
Closed
opened 2025-12-29 20:48:06 +01:00 by adam · 0 comments
adam commented 2025-12-29 20:48:06 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (Feb 27, 2024).

Originally assigned to: @jeremystretch on GitHub.

Proposed Changes

Drop the device_role property from the Device model, and the field from DeviceSerializer. (It has been superseded by role.)

Justification

The model field was renamed to role under #6391 in v3.6; this field was retained on the serializer for backward compatibility.

Impact

Any REST API clients which still reference the device_role field must be updated to use the role field, which contains the same data (and is writable).

Originally created by @jeremystretch on GitHub (Feb 27, 2024). Originally assigned to: @jeremystretch on GitHub. ### Proposed Changes Drop the `device_role` property from the `Device` model, and the field from `DeviceSerializer`. (It has been superseded by `role`.) ### Justification The model field was renamed to `role` under #6391 in v3.6; this field was retained on the serializer for backward compatibility. ### Impact Any REST API clients which still reference the `device_role` field must be updated to use the `role` field, which contains the same data (and is writable).
adam added the status: acceptedtype: deprecationbreaking change labels 2025-12-29 20:48:06 +01:00
adam closed this issue 2025-12-29 20:48:06 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label breaking change status: accepted type: deprecation
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#9302
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?