starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-12 05:20:31 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Clean up script execution logic #9210

New Issue
Closed
opened 2025-12-29 20:47:05 +01:00 by adam · 2 comments
adam commented 2025-12-29 20:47:05 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (Feb 7, 2024).

Proposed Changes

The logic currently in place for running custom scripts is in dire need of cleanup. Specifically, the internal _run_script() method relies on variables defined outside its scope, and needs to refactored/relocation.

Justification

Improvements in this area will make the code cleaner, easier to understand, and easier more maintainable long term.

Originally created by @jeremystretch on GitHub (Feb 7, 2024). ### Proposed Changes The logic currently in place for running custom scripts is in dire need of cleanup. Specifically, the internal `_run_script()` method relies on variables defined outside its scope, and needs to refactored/relocation. ### Justification Improvements in this area will make the code cleaner, easier to understand, and easier more maintainable long term.
adam added the type: housekeeping label 2025-12-29 20:47:05 +01:00
adam closed this issue 2025-12-29 20:47:05 +01:00
adam commented 2025-12-29 20:47:05 +01:00
Author
Owner
Copy Link

@github-actions[bot] commented on GitHub (May 15, 2024):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Do not attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our contributing guide.

@github-actions[bot] commented on GitHub (May 15, 2024): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. **Do not** attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our [contributing guide](https://github.com/netbox-community/netbox/blob/develop/CONTRIBUTING.md).
adam commented 2025-12-29 20:47:05 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Aug 14, 2024):

My initial concerns when raising this issue have generally been addressed by recent work.

@jeremystretch commented on GitHub (Aug 14, 2024): My initial concerns when raising this issue have generally been addressed by recent work.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label type: housekeeping
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#9210
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?