starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

add test mode to update.sh #9145

New Issue
Closed
opened 2025-12-29 20:46:15 +01:00 by adam · 5 comments
adam commented 2025-12-29 20:46:15 +01:00
Owner
Copy Link

Originally created by @spacklePatch on GitHub (Jan 24, 2024).

NetBox version

3.7.0

Feature type

New functionality

Proposed functionality

During the upgrade from a previous version, when upgrade.sh encounters unexpected data in the database, especially with old version data (we started with 2.x and upgraded to 3.3.7, now going to 3.7.0), an error it immediately stops. This is truly painful trying to revert and fix the errors in the data and try again, when we have no idea how many errors in data will be encountered.

Old data error example 1:
django.db.utils.IntegrityError: could not create unique index "dcim_device_unique_name_site"
DETAIL: Key (lower(name::text), site_id)=(cable mgt, 2955) is duplicated.

The above data used to allow case sensitive names of devices, but have the same characters. The is now longer the case, since the above Key contains (lower) method. this happened about 50 times, and would only fail on the 1st time.

Old data error example 2:
raise DataError(
django.db.utils.DataError: Unable to proceed with deleting asn field from Provider model: Found 1 providers with legacy ASN data. Please ensure all legacy provider ASN data has been migrated to ASN objects before proceeding. Or, set the NETBOX_DELETE_LEGACY_DATA environment variable to bypass this safeguard and delete all legacy provider ASN data.

This is just annoying and could be caught before hand with a Test mode.

Use case

upgrade.sh -Test would allow the upgraded to run in pretend mode and we can fix all errors encountered at once. Then run the upgrade in real mode 1 time with no errors,

Database changes

No response

External dependencies

No response

Originally created by @spacklePatch on GitHub (Jan 24, 2024). ### NetBox version 3.7.0 ### Feature type New functionality ### Proposed functionality During the upgrade from a previous version, when upgrade.sh encounters unexpected data in the database, especially with old version data (we started with 2.x and upgraded to 3.3.7, now going to 3.7.0), an error it immediately stops. This is truly painful trying to revert and fix the errors in the data and try again, when we have no idea how many errors in data will be encountered. Old data error example 1: **django.db.utils.IntegrityError: could not create unique index "dcim_device_unique_name_site" DETAIL: Key (lower(name::text), site_id)=(cable mgt, 2955) is duplicated.** The above data used to allow case sensitive names of devices, but have the same characters. The is now longer the case, since the above Key contains (lower) method. this happened about 50 times, and would only fail on the 1st time. Old data error example 2: raise DataError( **django.db.utils.DataError: Unable to proceed with deleting asn field from Provider model: Found 1 providers with legacy ASN data. Please ensure all legacy provider ASN data has been migrated to ASN objects before proceeding. Or, set the NETBOX_DELETE_LEGACY_DATA environment variable to bypass this safeguard and delete all legacy provider ASN data.** This is just annoying and could be caught before hand with a Test mode. ### Use case upgrade.sh -Test would allow the upgraded to run in pretend mode and we can fix all errors encountered at once. Then run the upgrade in real mode 1 time with no errors, ### Database changes _No response_ ### External dependencies _No response_
adam closed this issue 2025-12-29 20:46:15 +01:00
adam commented 2025-12-29 20:46:15 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Jan 24, 2024):

This is just annoying and could be caught before hand with a Test mode.

You haven't included any detail about your proposed implementation. What specifically would a "test mode" do?

@jeremystretch commented on GitHub (Jan 24, 2024): > This is just annoying and could be caught before hand with a Test mode. You haven't included any detail about your proposed implementation. What _specifically_ would a "test mode" do?
adam commented 2025-12-29 20:46:16 +01:00
Author
Owner
Copy Link

@spacklePatch commented on GitHub (Jan 24, 2024):

upgrade.sh -Test would allow the upgraded to run in pretend mode and we can fix all errors encountered at once. Then run the upgrade in real mode 1 time with no errors,

@spacklePatch commented on GitHub (Jan 24, 2024): upgrade.sh -Test would allow the upgraded to run in pretend mode and we can fix all errors encountered at once. Then run the upgrade in real mode 1 time with no errors,
adam commented 2025-12-29 20:46:16 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Jan 24, 2024):

upgrade.sh is just a shell script that calls individual commands. What is the specific set of commands you're proposing it runs to effect "pretend mode?"

@jeremystretch commented on GitHub (Jan 24, 2024): `upgrade.sh` is just a shell script that calls individual commands. What is the specific set of commands you're proposing it runs to effect "pretend mode?"
adam commented 2025-12-29 20:46:16 +01:00
Author
Owner
Copy Link

@spacklePatch commented on GitHub (Jan 24, 2024):

Honestly, I don't know exactly what is required to make this happen. It may not be part of upgrade.sh. I'm running Netbox and using it, but I am not programming it. This is a feature I'm requesting be added to the upgrade process.

@spacklePatch commented on GitHub (Jan 24, 2024): Honestly, I don't know exactly what is required to make this happen. It may not be part of upgrade.sh. I'm running Netbox and using it, but I am not programming it. This is a feature I'm requesting be added to the upgrade process.
adam commented 2025-12-29 20:46:17 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Jan 24, 2024):

Ok, I'm going to convert this to a discussion. Maybe someone else can weigh in to help you work out the specifics.

@jeremystretch commented on GitHub (Jan 24, 2024): Ok, I'm going to convert this to a discussion. Maybe someone else can weigh in to help you work out the specifics.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#9145
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?