mirror of
https://github.com/netbox-community/netbox.git
synced 2026-01-11 21:10:29 +01:00
No Branch/Tag Specified
main
update-changelog-comments-docs
feature-removal-issue-type
20911-dropdown
20239-plugin-menu-classes-mutable-state
21097-graphql-id-lookups
feature
fix_module_substitution
20923-dcim-templates
20044-elevation-stuck-lightmode
feature-ip-prefix-link
v4.5-beta1-release
20068-import-moduletype-attrs
20766-fix-german-translation-code-literals
20378-del-script
7604-filter-modifiers-v3
circuit-swap
12318-case-insensitive-uniqueness
20637-improve-device-q-filter
20660-script-load
19724-graphql
20614-update-ruff
14884-script
02496-max-page
19720-macaddress-interface-generic-relation
19408-circuit-terminations-export-templates
20203-openapi-check
fix-19669-api-image-download
7604-filter-modifiers
19275-fixes-interface-bulk-edit
fix-17794-get_field_value_return_list
11507-show-aggregate-and-rir-on-api
9583-add_column_specific_search_field_to_tables
v4.5.0
v4.4.10
v4.4.9
v4.5.0-beta1
v4.4.8
v4.4.7
v4.4.6
v4.4.5
v4.4.4
v4.4.3
v4.4.2
v4.4.1
v4.4.0
v4.3.7
v4.4.0-beta1
v4.3.6
v4.3.5
v4.3.4
v4.3.3
v4.3.2
v4.3.1
v4.3.0
v4.2.9
v4.3.0-beta2
v4.2.8
v4.3.0-beta1
v4.2.7
v4.2.6
v4.2.5
v4.2.4
v4.2.3
v4.2.2
v4.2.1
v4.2.0
v4.1.11
v4.1.10
v4.1.9
v4.1.8
v4.2-beta1
v4.1.7
v4.1.6
v4.1.5
v4.1.4
v4.1.3
v4.1.2
v4.1.1
v4.1.0
v4.0.11
v4.0.10
v4.0.9
v4.1-beta1
v4.0.8
v4.0.7
v4.0.6
v4.0.5
v4.0.3
v4.0.2
v4.0.1
v4.0.0
v3.7.8
v3.7.7
v4.0-beta2
v3.7.6
v3.7.5
v4.0-beta1
v3.7.4
v3.7.3
v3.7.2
v3.7.1
v3.7.0
v3.6.9
v3.6.8
v3.6.7
v3.7-beta1
v3.6.6
v3.6.5
v3.6.4
v3.6.3
v3.6.2
v3.6.1
v3.6.0
v3.5.9
v3.6-beta2
v3.5.8
v3.6-beta1
v3.5.7
v3.5.6
v3.5.5
v3.5.4
v3.5.3
v3.5.2
v3.5.1
v3.5.0
v3.4.10
v3.4.9
v3.5-beta2
v3.4.8
v3.5-beta1
v3.4.7
v3.4.6
v3.4.5
v3.4.4
v3.4.3
v3.4.2
v3.4.1
v3.4.0
v3.3.10
v3.3.9
v3.4-beta1
v3.3.8
v3.3.7
v3.3.6
v3.3.5
v3.3.4
v3.3.3
v3.3.2
v3.3.1
v3.3.0
v3.2.9
v3.2.8
v3.3-beta2
v3.2.7
v3.3-beta1
v3.2.6
v3.2.5
v3.2.4
v3.2.3
v3.2.2
v3.2.1
v3.2.0
v3.1.11
v3.1.10
v3.2-beta2
v3.1.9
v3.2-beta1
v3.1.8
v3.1.7
v3.1.6
v3.1.5
v3.1.4
v3.1.3
v3.1.2
v3.1.1
v3.1.0
v3.0.12
v3.0.11
v3.0.10
v3.1-beta1
v3.0.9
v3.0.8
v3.0.7
v3.0.6
v3.0.5
v3.0.4
v3.0.3
v3.0.2
v3.0.1
v3.0.0
v2.11.12
v3.0-beta2
v2.11.11
v2.11.10
v3.0-beta1
v2.11.9
v2.11.8
v2.11.7
v2.11.6
v2.11.5
v2.11.4
v2.11.3
v2.11.2
v2.11.1
v2.11.0
v2.10.10
v2.10.9
v2.11-beta1
v2.10.8
v2.10.7
v2.10.6
v2.10.5
v2.10.4
v2.10.3
v2.10.2
v2.10.1
v2.10.0
v2.9.11
v2.10-beta2
v2.9.10
v2.10-beta1
v2.9.9
v2.9.8
v2.9.7
v2.9.6
v2.9.5
v2.9.4
v2.9.3
v2.9.2
v2.9.1
v2.9.0
v2.9-beta2
v2.8.9
v2.9-beta1
v2.8.8
v2.8.7
v2.8.6
v2.8.5
v2.8.4
v2.8.3
v2.8.2
v2.8.1
v2.8.0
v2.7.12
v2.7.11
v2.7.10
v2.7.9
v2.7.8
v2.7.7
v2.7.6
v2.7.5
v2.7.4
v2.7.3
v2.7.2
v2.7.1
v2.7.0
v2.6.12
v2.6.11
v2.6.10
v2.6.9
v2.7-beta1
Solcon-2020-01-06
v2.6.8
v2.6.7
v2.6.6
v2.6.5
v2.6.4
v2.6.3
v2.6.2
v2.6.1
v2.6.0
v2.5.13
v2.5.12
v2.6-beta1
v2.5.11
v2.5.10
v2.5.9
v2.5.8
v2.5.7
v2.5.6
v2.5.5
v2.5.4
v2.5.3
v2.5.2
v2.5.1
v2.5.0
v2.4.9
v2.5-beta2
v2.4.8
v2.5-beta1
v2.4.7
v2.4.6
v2.4.5
v2.4.4
v2.4.3
v2.4.2
v2.4.1
v2.4.0
v2.3.7
v2.4-beta1
v2.3.6
v2.3.5
v2.3.4
v2.3.3
v2.3.2
v2.3.1
v2.3.0
v2.2.10
v2.3-beta2
v2.2.9
v2.3-beta1
v2.2.8
v2.2.7
v2.2.6
v2.2.5
v2.2.4
v2.2.3
v2.2.2
v2.2.1
v2.2.0
v2.1.6
v2.2-beta2
v2.1.5
v2.2-beta1
v2.1.4
v2.1.3
v2.1.2
v2.1.1
v2.1.0
v2.0.10
v2.1-beta1
v2.0.9
v2.0.8
v2.0.7
v2.0.6
v2.0.5
v2.0.4
v2.0.3
v2.0.2
v2.0.1
v2.0.0
v2.0-beta3
v1.9.6
v1.9.5
v2.0-beta2
v1.9.4-r1
v1.9.3
v2.0-beta1
v1.9.2
v1.9.1
v1.9.0-r1
v1.8.4
v1.8.3
v1.8.2
v1.8.1
v1.8.0
v1.7.3
v1.7.2-r1
v1.7.1
v1.7.0
v1.6.3
v1.6.2-r1
v1.6.1-r1
1.6.1
v1.6.0
v1.5.2
v1.5.1
v1.5.0
v1.4.2
v1.4.1
v1.4.0
v1.3.2
v1.3.1
v1.3.0
v1.2.2
v1.2.1
v1.2.0
v1.1.0
v1.0.7-r1
v1.0.7
v1.0.6
v1.0.5
v1.0.4
v1.0.3-r1
v1.0.3
1.0.0
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
Mirrored from GitHub Pull Request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: starred/netbox#9117
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @jeremystretch on GitHub (Jan 19, 2024).
Originally assigned to: @jeremystretch on GitHub.
Proposed Changes
This issue serves to track miscellaneous cleanup work following the UI refresh in #12128 for NetBox v4.0. It will be kept open for a while as we continue to uncover and address minor UI issues. (Note that this issue is not a suitable place for proposing any new functionality or otherwise substantial UI changes.)
Please add any new items in a comment below (including a screenshot where helpful), and it will be added here.
Allow object list tables to expand horizontally beyond the default page width where beneficialSee [PR #18377] [MERGED] Fixes #18376: Include tagged VLANs in interfaces list for Q-in-Q interfaces (#15339)netbox-datablock from the base template & and the obsoletegetNetboxData()function<p>element in rendered Markdown inside a table cell.btn-sm) buttonsEliminate "flash" on load when dark mode has been set via toggle button (vs. user preference)See [PR #18370] [MERGED] Fixes #18368: Restore missing fields on REST API serializer for MAC addresses (#15340)span.color-labeldisplay toinline-blockJustification
We're tracking this work under a shared issue as they're mostly small, iterative changes that alone aren't very significant (e.g. tweaking HTML templates or applying a missing CSS class).
@ITJamie commented on GitHub (Jan 20, 2024):
When deleting a bookmark the dialog is written as if its about to delete the actual object not a bookmark to the object https://github.com/netbox-community/netbox/issues/13842
@jeremystretch commented on GitHub (Jan 22, 2024):
@ITJamie the scope of this issue is limited to UI changes resulting from work done under #12128. Anything else needs to be tracked under a separate issue.
@jeremystretch commented on GitHub (Jan 23, 2024):
It appears that
dcim/inventoryitem_bulk_delete.htmlis no longer in use; there may be other obsolete templates as well. We should do a quick audit.@jeremystretch commented on GitHub (Jan 23, 2024):
Reduce vertical space between a checkbox field and its help text.

@jeremystretch commented on GitHub (Jan 23, 2024):
Remove ghost shadow from hidden "clear" button on quick search (barely visible to right of search field)
@jeremystretch commented on GitHub (Jan 23, 2024):
Hide/show dropdown button on new line under device interfaces view
@cybarox commented on GitHub (Jan 25, 2024):
Tables in tableviews using not the full width
Sites:



Prefixes:
Circuits:
The margin of the little red cross for unset the sorting setting is also overlapped by the column title.
@cybarox commented on GitHub (Jan 25, 2024):
On Device View:

The button "highlight device" has no margin to the right.
Custom Field Topics are not styled.
@jeremystretch commented on GitHub (Jan 25, 2024):
We're currently using a maximum width for all page content (this was done to bolster readability for object detail views) but I suppose we could use a full-width view for object lists. We should however give some thought to limiting the width of tables with few columns: Viewing e.g. the platforms list on a very wide viewport is a bit taxing for the user.
@cybarox commented on GitHub (Jan 25, 2024):
Avoiding superfluous space in tables is certainly good, my concern would be that if different tables have different widths as a result (e.g. if the user adds custom-field columns) , the overall impression of the UI could quickly become restless or appear inconsistent.
Perhaps the max-width variant can be used for tables whose columns are narrow enough to display them in this way. All content that requires a larger width could then be displayed as a full-width table.
Another possibility would be to let the user decide for himself and add a toggle option to the configure table menu.
@jeremystretch commented on GitHub (Jan 30, 2024):
On many pages, we include an "add" button beneath embedded object tables. For instance:
We can save a considerable amount of space by relocating this button to the card header, opposite its title, and reducing its size.
@jeremystretch commented on GitHub (Jan 30, 2024):
Fix margin around the "map it" button for site addresses.
@jeremystretch commented on GitHub (Feb 6, 2024):
Rendered Markdown content inside a table cell (e.g. in script output) has extra white space, due to the bottom margin applied to

<p>elements. It's probably safe to negate this margin for the last<p>element inside a table cell.@arthanson commented on GitHub (Feb 8, 2024):
minor esthetic - the copy and action dropdown buttons on the right-side are not rounded and look out of place, the old ones were rounded and blended in better:

@peteeckel commented on GitHub (Feb 8, 2024):
Another aesthetic issue: When switching views in dark mode, the new stuff on the right side is often initially loaded in bright mode and then immediately switches to dark mode. This results in an unpleasant "flashing" while navigating.
Tested with Safari, Chromium and Firefox. With Chromium and Firefox the effect is more pronounced, but with Safari it's visible as well.
https://github.com/netbox-community/netbox/assets/6815386/4767a155-1090-457c-b77c-acaf0075a57b
Update: This only happens when the current light/dark mode setting is different from the one in the user's preferences, i.e. if the mode has been set via the "light bulb" button in the upper right corner. If the current setting is the same as the one in the preferences it's OK.
If the preferences are set to "dark mode" and the current mode is set to "light", the effect is reversed, i.e. dark flashing.
@peteeckel commented on GitHub (Feb 8, 2024):
Another aesthetic issue ... is there any reason why dark modes sports a somewhat bluish and pale color schema? The NetBox windows stand out from all my windows in dark mode, most of which are more or less black.
@peteeckel commented on GitHub (Feb 9, 2024):
Some peculiarity after the switch to
tom-select(at least I noticed it after pulling yesterday's commits, current SHAd63e1da):In long pull-down menus (
forms.multipleChoiceFieldin this case) only the first 50 entries are displayed, without an indication that the list is truncated. Entering some characters will, however, make it possible to select the later ones as well.It would be good if there were an indicator of the truncation (ideally with an option to load and display the remainder of the items), or if that behaviour could be made optional.
@peteeckel commented on GitHub (Feb 9, 2024):
The "Table Configuration" form is broken:
Neither the list of available columns nor the list of selected columns is visible (wrong widget, probably). As a consequence, re-ordering columns is not possible.
@peteeckel commented on GitHub (Feb 9, 2024):
Another observation regarding the color scheme: In the old UI, the section headers had a darker colour than the actual menu items. This differentiation has gone in the new UI, which makes it difficult to differentiate between headers and menu items.
Adding to the fact is that the buttons are only displayed on mouseover, taking away a second optical differentiation.
This is also responsible for my somewhat erratic menu navigation in the screen recording above :-)
@jeremystretch commented on GitHub (Feb 9, 2024):
50 was the default limit but it was raised to 100; dropdowns should always be populating with up to 100 options currently.
I was initially going to port over the pagination functionality from the original APISelect widget, but it didn't seem to be worthwhile IMO. You figure people are generally going to stop scrolling and start typing by the time they've skimmed through a hundred options. I'm open to arguments to retain the functionality though.
@jeremystretch commented on GitHub (Feb 9, 2024):
This is just the default dark mode color scheme provided by Tabler. I honestly didn't even notice the blue tint until you pointed it out (I struggle with differentiating between blue and black). Happy to entertain changes to the color scheme, but this probably something best tackled in a separate issue as 1) color is highly subjective and 2) we'll need to consider the entire palette for consistency.
@peteeckel commented on GitHub (Feb 9, 2024):
That gets me confused as well, I found
in
netbox/project-static/src/select/dynamic.ts. But I can still only see the first 50 elements.@jeremystretch commented on GitHub (Feb 9, 2024):
On the circuit edit form, the border of the dropdown button next to the commit rate field is too dark.
@peteeckel commented on GitHub (Feb 9, 2024):
But in any case it would help to indicate somehow that the list isn't complete, or I'm sure people will find the record types end with 'NXT' and complain that e.g. 'SPF' is missing ...
@jeremystretch commented on GitHub (Feb 10, 2024):
@peteeckel sorry, it just clicked with me earlier that you're looking at a static dropdown rather than one being populated via the API; I only increased
MAX_ITEMSfor the later. We should probably remove the limit for static dropdowns.Edit: This has been fixed in the
featurebranch as part of #14917.@jeremystretch commented on GitHub (Feb 13, 2024):
When viewing the dashboard, the full page width is consumed, however the search bar (top left) and user menu (top right) are constrained to the container width.
@peteeckel commented on GitHub (Feb 15, 2024):
Another issue with the color scheme, and again with dark mode:
I didn't notice it that much when using dark mode at night, but by day the contrast between the row headers and the background in detail view is much too low - almost unreadably. Light mode is fine.
@jeremystretch commented on GitHub (Feb 15, 2024):
The border of the "copy-to-clipboard" button is too dark
@kkthxbye-code commented on GitHub (Feb 17, 2024):
The below commit incorrectly assumes that it is always okay to clear child select fields when the parent changes. This is not the case for the cable form where multiple interfaces from different devices can be selected in the same a/b-side interface select field.
674f794c69The form element:
Here the interface field would be cleared if the device was changed.
@kkthxbye-code commented on GitHub (Feb 17, 2024):
The object selector doesn't work and looks wrong:
@kkthxbye-code commented on GitHub (Feb 17, 2024):
Toast notifications look wrong in dark mode, text blends in:
@peteeckel commented on GitHub (Feb 17, 2024):
Agreed - but it's a functionality sorely missed in NetBox < 4, so probably the best would be to have it selectable as an option.
@peteeckel commented on GitHub (Feb 20, 2024):
Another
tom-selectglitch: When you enter search text in aDynamicModelMultipleChoiceFieldto narrow down the selection and then click on one of the resulting items, the search text is still present in the box:The same does not happen with
DynamicModelField.Update: This might be intended, it's just irritating - the first few times I tried to backspace until the text goes away, often inadvertently removing the last object, then I found that the text disappears on saving.
@jeremystretch commented on GitHub (Feb 22, 2024):
@peteeckel sorry I think I deleted your latest comment by mistake.
@jeremystretch commented on GitHub (Feb 22, 2024):
Just a reminder: This thread is for cosmetic issues stemming from the migration to Tabler. Any functional issues with tom-select or other components are out of scope for this thread, and will need to be addressed separately.
@jeremystretch commented on GitHub (Mar 4, 2024):
Closing this as all the minor items have been addressed, and the others have been spun off into separate issues. For any suspected UI issues moving forward, please submit a new bug report.