starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Relax requirement for IKE policy #9108

New Issue
Closed
opened 2025-12-29 20:45:31 +01:00 by adam · 4 comments
adam commented 2025-12-29 20:45:31 +01:00
Owner
Copy Link

Originally created by @m2martin on GitHub (Jan 18, 2024).

Originally assigned to: @m2martin on GitHub.

Deployment Type

Self-hosted

NetBox Version

v3.7.1

Python Version

3.9

Steps to Reproduce

  1. Go to IKE policies and add a policy
  2. Field Mode is required and provides Aggressive and Main

Expected Behavior

Field Mode is not required.

Observed Behavior

Field Mode is required.

Originally created by @m2martin on GitHub (Jan 18, 2024). Originally assigned to: @m2martin on GitHub. ### Deployment Type Self-hosted ### NetBox Version v3.7.1 ### Python Version 3.9 ### Steps to Reproduce 1. Go to IKE policies and add a policy 2. Field `Mode` is required and provides `Aggressive` and `Main` ### Expected Behavior Field `Mode` _is not_ required. ### Observed Behavior Field `Mode` _is_ required.
adam added the type: bugstatus: acceptedseverity: low labels 2025-12-29 20:45:31 +01:00
adam closed this issue 2025-12-29 20:45:32 +01:00
adam commented 2025-12-29 20:45:32 +01:00
Author
Owner
Copy Link

@m2martin commented on GitHub (Jan 18, 2024):

Background:

One of the substential differences between IKEv1 and IKEv2 is the initial message exchange which has no configurable modes (Main/Aggressive) compared to v1.

The field Mode should not be required like Authentication algo in IKE proposals which depends on the encryption algo (CBC/GCM) (see #14499).

...yes I know...blank=True would need a migration.

@m2martin commented on GitHub (Jan 18, 2024): Background: One of the substential differences between IKEv1 and IKEv2 is the initial message exchange which has no configurable modes (Main/Aggressive) compared to v1. The field `Mode` should not be required like Authentication algo in IKE proposals which depends on the encryption algo (CBC/GCM) (see #14499). ...yes I know...`blank=True` would need a migration.
adam commented 2025-12-29 20:45:32 +01:00
Author
Owner
Copy Link

@DanSheps commented on GitHub (Jan 19, 2024):

If someone wants to tackle this, the best way forward would be:

  • set blank=True and null=True on the model (build the migration as well
  • Edit the model clean method to require IKEv1 to have a mode of any of the choices
@DanSheps commented on GitHub (Jan 19, 2024): If someone wants to tackle this, the best way forward would be: * set `blank=True` and `null=True` on the model (build the migration as well * Edit the model `clean` method to require IKEv1 to have a mode of any of the choices
adam commented 2025-12-29 20:45:32 +01:00
Author
Owner
Copy Link

@m2martin commented on GitHub (Jan 19, 2024):

If the change is basically accepted, I'd implement it accordingly.

@m2martin commented on GitHub (Jan 19, 2024): If the change is basically accepted, I'd implement it accordingly.
adam commented 2025-12-29 20:45:33 +01:00
Author
Owner
Copy Link

@DanSheps commented on GitHub (Jan 19, 2024):

If the change is basically accepted, I'd implement it accordingly.

All you @m2martin

@DanSheps commented on GitHub (Jan 19, 2024): > If the change is basically accepted, I'd implement it accordingly. All you @m2martin
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label severity: low status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#9108
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?