starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Manufacturer displayed as required for Device import #9052

New Issue
Closed
opened 2025-12-29 20:44:50 +01:00 by adam · 5 comments
adam commented 2025-12-29 20:44:50 +01:00
Owner
Copy Link

Originally created by @wz4 on GitHub (Jan 6, 2024).

Deployment Type

Self-hosted

NetBox Version

v3.7.0

Python Version

3.10

Steps to Reproduce

'Device' import displays 'manufacturer' as a required field, but manufacturer is not associated with the Device model.

Expected Behavior

Manufacturer should not be listed as a required field for Device import.

Observed Behavior

Failed: Device() got unexpected keyword arguments: 'manufacturer'

Originally created by @wz4 on GitHub (Jan 6, 2024). ### Deployment Type Self-hosted ### NetBox Version v3.7.0 ### Python Version 3.10 ### Steps to Reproduce 'Device' import displays 'manufacturer' as a required field, but manufacturer is not associated with the Device model. ### Expected Behavior Manufacturer should not be listed as a required field for Device import. ### Observed Behavior Failed: Device() got unexpected keyword arguments: 'manufacturer'
adam added the type: bugstatus: revisions needed labels 2025-12-29 20:44:50 +01:00
adam closed this issue 2025-12-29 20:44:50 +01:00
adam commented 2025-12-29 20:44:51 +01:00
Author
Owner
Copy Link

@CTV-2023 commented on GitHub (Jan 6, 2024):

Maybe because you also need to provide a device type, linked to a manufacturer ? (I don't remember if you can have two identical devices types with different manufacturers, seems strange but there might be an use case)

@CTV-2023 commented on GitHub (Jan 6, 2024): Maybe because you also need to provide a device type, linked to a manufacturer ? (I don't remember if you can have two identical devices types with different manufacturers, seems strange but there might be an use case)
adam commented 2025-12-29 20:44:51 +01:00
Author
Owner
Copy Link

@ross-cello commented on GitHub (Jan 7, 2024):

I don't think you can create a device type without specifying a manufacturer?

@ross-cello commented on GitHub (Jan 7, 2024): I don't think you can create a device type without specifying a manufacturer?
adam commented 2025-12-29 20:44:51 +01:00
Author
Owner
Copy Link

@wz4 commented on GitHub (Jan 7, 2024):

Yes, but for a device csv import only device_type is required. I’m sure there are other instances with nested requirements that are not explicitly listed as in this case.

@wz4 commented on GitHub (Jan 7, 2024): Yes, but for a device csv import only device_type is required. I’m sure there are other instances with nested requirements that are not explicitly listed as in this case.
adam commented 2025-12-29 20:44:51 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Jan 8, 2024):

Thank you for opening a bug report. Unfortunately, the information you have provided is not sufficient for someone else to attempt to reproduce the reported behavior. Remember, each bug report must include detailed steps that someone else can follow on a clean, empty NetBox installation to reproduce the exact problem you're experiencing. These instructions should include the creation of any involved objects, any configuration changes, and complete accounting of the actions being taken. Also be sure that your report does not reference data on the public NetBox demo, as that is subject to change at any time by an outside party and cannot be relied upon for bug reports.

@jeremystretch commented on GitHub (Jan 8, 2024): Thank you for opening a bug report. Unfortunately, the information you have provided is not sufficient for someone else to attempt to reproduce the reported behavior. Remember, each bug report must include detailed steps that someone else can follow on a clean, empty NetBox installation to reproduce the exact problem you're experiencing. These instructions should include the creation of any involved objects, any configuration changes, and complete accounting of the actions being taken. Also be sure that your report does not reference data on the public NetBox demo, as that is subject to change at any time by an outside party and cannot be relied upon for bug reports.
adam commented 2025-12-29 20:44:52 +01:00
Author
Owner
Copy Link

@wz4 commented on GitHub (Jan 8, 2024):

I am going to close this, because csv import still works if manufacturer is listed. I referenced the required fields when creating a custom script, which resulted in the error. Source code should be used to validate model fields.

@wz4 commented on GitHub (Jan 8, 2024): I am going to close this, because csv import still works if manufacturer is listed. I referenced the required fields when creating a custom script, which resulted in the error. Source code should be used to validate model fields.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: revisions needed type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#9052
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?