starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Remove results query from extras/views.py under ScriptView.get() #8989

New Issue
Closed
opened 2025-12-29 20:43:54 +01:00 by adam · 0 comments
adam commented 2025-12-29 20:43:54 +01:00
Owner
Copy Link

Originally created by @DanSheps on GitHub (Dec 20, 2023).

Originally assigned to: @DanSheps on GitHub.

Proposed Changes

Remove:

        # Look for a pending Job (use the latest one by creation timestamp)
        object_type = ContentType.objects.get(app_label='extras', model='scriptmodule')
        script.result = Job.objects.filter(
            object_type=object_type,
            object_id=module.pk,
            name=script.class_name,
        ).exclude(
            status__in=JobStatusChoices.TERMINAL_STATE_CHOICES
        ).first()

Justification

This appears to be extraneous code that was left over from when results were handled inline. This is no longer needed as the result is a separate view.

result is not referenced anywhere in the template.

Originally created by @DanSheps on GitHub (Dec 20, 2023). Originally assigned to: @DanSheps on GitHub. ### Proposed Changes Remove: ``` # Look for a pending Job (use the latest one by creation timestamp) object_type = ContentType.objects.get(app_label='extras', model='scriptmodule') script.result = Job.objects.filter( object_type=object_type, object_id=module.pk, name=script.class_name, ).exclude( status__in=JobStatusChoices.TERMINAL_STATE_CHOICES ).first() ``` ### Justification This appears to be extraneous code that was left over from when results were handled inline. This is no longer needed as the result is a separate view. `result` is not referenced anywhere in the template.
adam added the status: acceptedtype: housekeeping labels 2025-12-29 20:43:54 +01:00
adam closed this issue 2025-12-29 20:43:55 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: housekeeping
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#8989
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?