starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Usage of exclamation mark (!) in Custom Links not possible #8987

New Issue
Closed
opened 2025-12-29 20:43:52 +01:00 by adam · 2 comments
adam commented 2025-12-29 20:43:52 +01:00
Owner
Copy Link

Originally created by @Azmodeszer on GitHub (Dec 19, 2023).

Originally assigned to: @Azmodeszer on GitHub.

Deployment Type

Self-hosted

NetBox Version

3.6.6

Python Version

3.11

Steps to Reproduce

  1. Set up a Custom Link.
  2. Put https://<IP>/screens/dashboard.html#!/APView/{{ object.interfaces.filter(mac_address__isnull=False).first().mac_address }} as the Link URL.

Similar to #13011. Also see #14553.

Expected Behavior

The URL should be rendered with the ! intact.

Observed Behavior

The ! is encoded as %21, resulting in a broken link.

Originally created by @Azmodeszer on GitHub (Dec 19, 2023). Originally assigned to: @Azmodeszer on GitHub. ### Deployment Type Self-hosted ### NetBox Version 3.6.6 ### Python Version 3.11 ### Steps to Reproduce 1. Set up a Custom Link. 2. Put `https://<IP>/screens/dashboard.html#!/APView/{{ object.interfaces.filter(mac_address__isnull=False).first().mac_address }}` as the Link URL. Similar to #13011. Also see #14553. ### Expected Behavior The URL should be rendered with the ! intact. ### Observed Behavior The ! is encoded as %21, resulting in a broken link.
adam added the type: bugstatus: acceptedseverity: low labels 2025-12-29 20:43:52 +01:00
adam closed this issue 2025-12-29 20:43:52 +01:00
adam commented 2025-12-29 20:43:53 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Dec 21, 2023):

The exclamation mark probably needs to be added to the list of characters excluded from escaping when calling urllib.parse.quote().

@jeremystretch commented on GitHub (Dec 21, 2023): The exclamation mark probably needs to be added to the list of characters excluded from escaping when calling `urllib.parse.quote()`.
adam commented 2025-12-29 20:43:53 +01:00
Author
Owner
Copy Link

@Azmodeszer commented on GitHub (Dec 21, 2023):

I can own this and do the pull request, no problem.

@Azmodeszer commented on GitHub (Dec 21, 2023): I can own this and do the pull request, no problem.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label severity: low status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#8987
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?